Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fixing information_schema.columns.is_identity #61348

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

mnovelodou
Copy link
Contributor

Previously, information_schema.columns.is_identity was set to null
This was inadequate because is incorrect value
To address this, this patch sets column to NO as identity columns
are not yet supported

Release justification: bug fixes and low-risk updates to new functionality
Release note (sql change): fixed information_schema.columns.is_identity to
display the correct value

Fixes #61011

Previously, information_schema.columns.is_identity was set to null
This was inadequate because is incorrect value
To address this, this patch sets column to NO as identity columns
are not yet supported

Release justification: bug fixes and low-risk updates to new functionality
Release note (sql change): fixed information_schema.columns.is_identity to
display the correct value

Fixes cockroachdb#61011
@blathers-crl
Copy link

blathers-crl bot commented Mar 2, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Mar 2, 2021
@blathers-crl blathers-crl bot requested review from arulajmani and rafiss March 2, 2021 17:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 3, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 3, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Mar 3, 2021

Build succeeded:

@craig craig bot merged commit 4ab29d4 into cockroachdb:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: fill information_schema.columns.is_identity correctly
3 participants