build: bazel build cockroach-short fails on BSD

[knz]

Running

bazel build //pkg/cmd/cockroach-short |& tee failure.log

produces this failure log

Then:

bazel build //pkg/cmd/cockroach-short --verbose_failures |& tee failure-verbose.log

produces this verbose log

Attached copy of bazel-out/.../libroach/logs/CMake.log

Futher instructions needed?

[irfansharif]

ln: illegal option -- t
usage: ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file [target_file]
       ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file ... target_dir
       link source_file target_file

Looks like the bazel internal linking scripts seem to use an illegal option.

...
_____ BEGIN BUILD SCRIPT _____
#!/usr/bin/env bash
function symlink_to_dir() {
local target="$2"
mkdir -p "$target"
if [[ -f "$1" ]]; then
ln -s -f -t "$target" "$1"

[knz]

It's very odd because if $target already exists and is a directory (it is here! thanks to mkdir just before) then -t is not needed: ln -s will already do the right thing.

[knz]

can we just have that remove the -t flag?

[irfansharif]

Probably, but it's not part of our bazel we've yet touched by hand. Would need further investigation (bazel on non-darwin systems generally still do). Mind sharing for posterity the machine/distro you're running it on? Because it's not an issue I'm seeing on my box.

[knz]

BSD.

BSD ln does not support -t.

[otan]

We'd need to copy this for BSD but remove the -t option: https://github.com/bazelbuild/rules_foreign_cc/blob/master/tools/build_defs/shell_toolchain/toolchains/impl/default_commands.bzl#L87

And then set a specific option for BSD: https://github.com/bazelbuild/rules_foreign_cc/blob/master/tools/build_defs/shell_toolchain/toolchains/toolchain_mappings.bzl#L33

Once grafted on, this needs to be placed on top of my branch in https://github.com/otan-cockroach/rules_foreign_cc/tree/autoconf and the WORKSPACE will need to change afterwards at https://github.com/cockroachdb/cockroach/blob/master/WORKSPACE#L68. We can submit a review in the main repo in the meantime, but my existing PR there has not been looked at.

---

As an aside, we should invest in dedicated machines so that everyone is compiling on same environment. Or more annoyingly, make bazel build inside the same docker container for everyone. Food for thought @jlinder? statement retracted - this would alienate the open source community.

[knz]

FWIW docker doesn't work on BSD systems (even macOS has problems). Native builds are a pre

[otan]

bazel-contrib/rules_foreign_cc#387

this would fix it. but there's no love from the maintainers :(