Add specific shell command support for FreeBSD. #387
Conversation
The main change is to use the versions of cp and ln from the coreutils package, which support all the options that Bazel is expecting -- the default versions do not.
... according to recent general changes in bazel-contrib#377.
|
This is great! |
Fixes cockroachdb#56013. We're picking up bazel-contrib/rules_foreign_cc/pull/387 (included in our new fork at cockroachdb/rules_foreign_cc). We've also picked up Oliver's PR adding autoconf support (bazel-contrib/rules_foreign_cc/pull/432); we were pointing to Oliver's own fork previously to pick up those changes. Release note: None
57030: execgen: permit customization of template path r=jordanlewis a=jordanlewis Closes #56982 This commit adds a new argument to execgen, -template, which allows customization of the file path of the input template for a given output file. Here's an example of how to run execgen with cutomized paths: ``` execgen -template path/to/template_tmpl.go path/to/eventual/generated/code.eg.go > path/to/wherever/you/want/to/write/the/file.eg.o ``` The second argument is important because it is used as an argument to `goimports`, which needs to the actual, eventual path that the generated code will live at. Note that it doesn't actually need to *write* to that filepath - just needs to know what the name will be, eventually. Release note: None 57039: bazel: add freebsd support r=irfansharif a=irfansharif Fixes #56013. We're picking up bazel-contrib/rules_foreign_cc/pull/387 (included in our new fork at [cockroachdb/rules_foreign_cc](https://github.com/cockroachdb/rules_foreign_cc/)). We've also picked up Oliver's PR adding autoconf support (bazel-contrib/rules_foreign_cc/pull/432); we were pointing to Oliver's own fork previously to pick up those changes. Release note: None --- @knz, wanna try this branch out and see if it works? If not, I should probably spin up a freebsd AMI next once someone shows me how. Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: irfan sharif <[email protected]>
|
Oof, looks like CI isn't happy about something. @gbrail if you have time to take a look, I'd be happy to merge these changes 😄 |
| elif [[ -L "$1" ]]; then | ||
| gcp $1 $2 | ||
| elif [[ -d "$1" ]]; then | ||
| local children=$(find -H "$1" -maxdepth 1 -mindepth 1) |
There was a problem hiding this comment.
There was a recent bugfix for this section of code on other platforms. Does this also suffer from the same issue solved in #416 ?
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc! |
|
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
The main change is to use the versions of cp and ln from the coreutils
package, which support all the options that Bazel is expecting -- the
default versions do not.
(Please note that I'm not a BSD expert -- but I have a small project that builds and runs there and this change helped me move forward.)