Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: "traceLocation" is dead code #40990

Closed
knz opened this issue Sep 23, 2019 · 0 comments · Fixed by #43899
Closed

log: "traceLocation" is dead code #40990

knz opened this issue Sep 23, 2019 · 0 comments · Fixed by #43899
Labels
A-logging In and around the logging infrastructure. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@knz
Copy link
Contributor

knz commented Sep 23, 2019

The log package has a special "trace point" feature that's not used anywhere.

Presumably it was originally intended to be configurable via a ghost flag -log_backtrace_at (mentioned in comments), but today it's not used anywhere.

cc @tbg
@knz knz added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-logging In and around the logging infrastructure. labels Sep 23, 2019
@knz knz mentioned this issue Sep 23, 2019
Merged
craig bot pushed a commit that referenced this issue Oct 17, 2019
@knz @jordanlewis
Merge #40993 #41654
0e655a3 
40993: util/log: refactor and bug fixes r=knz a=knz

Fixes #40983.
Fixes #40973.
Fixes #40974.
Fixes #41231.

I might also want to add code to clean up #40972, #40982 and #40990 provided I receive some guidance from @tbg or someone familiar with the log package.


41654: parser: fix telemetry link for materialized views r=jordanlewis a=jordanlewis

This commit fixes the error message that you get if you try to create a
materialized view to point at the right GitHub issue.

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Jordan Lewis <[email protected]>
@knz knz mentioned this issue Jan 13, 2020
Merged
@craig craig bot closed this as completed in 251512b Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/log: remove some dead code knz/cockroach
1 participant
@knz