Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: the Intercept() mechanism only works for the main log #40973

Closed
knz opened this issue Sep 23, 2019 · 0 comments · Fixed by #40993
Closed

log: the Intercept() mechanism only works for the main log #40973

knz opened this issue Sep 23, 2019 · 0 comments · Fixed by #40993
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Sep 23, 2019

The log package provides an Intercept() function used by the "logspy" debug endpoint.

At this time Intercept() only redirects logging to the main logger. Secondary loggers (SQL audit log, statements, RocksDB) are not intercepted.

Presumably we want interception to work across all loggers simultaneously.

cc @tbg
@knz knz added A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Sep 23, 2019
@knz knz mentioned this issue Sep 23, 2019
Merged
@craig craig bot closed this as completed in 0e655a3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/log: refactor and bug fixes knz/cockroach
1 participant
@knz