Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: re-enable multiple PAUSE in test/TestBackupRestoreControlJob/pause #40638

Closed
spaskob opened this issue Sep 10, 2019 · 0 comments
Closed

backupccl: re-enable multiple PAUSE in test/TestBackupRestoreControlJob/pause #40638

spaskob opened this issue Sep 10, 2019 · 0 comments
Labels
A-disaster-recovery T-disaster-recovery

Comments

@spaskob
Copy link
Contributor

spaskob commented Sep 10, 2019 •
edited by cockroach-jira-scripts
Loading

The test scenario was simplified because of test flakiness that was impractical and too complex to fix. Re-enable the more comprehensive scenario once job control infrastructure is improved.

See also #24136.

Epic CRDB-7776

Jira issue: CRDB-5530
@spaskob spaskob self-assigned this Sep 10, 2019
@spaskob spaskob mentioned this issue Sep 10, 2019
Closed
spaskob pushed a commit to spaskob/cockroach that referenced this issue Sep 26, 2019
backupccl: enable skipped test
88370d7 
The test was flaky and hence skipped for quite sometime.
I wasn't able to fix it in it's current form because of
the complexity of how we enable job control statements
today. This will be revisited once we have a saner
implementation. The folloup is tracked at cockroachdb#40638.

Touches cockroachdb#40638.
Fixes cockroachdb#24136.

Release notes (bug fix): none.
spaskob added a commit to spaskob/cockroach that referenced this issue Jan 31, 2020
@spaskob
backupccl: enable skipped backup test
9a4b62d 
The test was flaky and hence skipped for quite sometime.
I wasn't able to fix it in it's current form because of
the complexity of how we enable job control statements
today. This will be revisited once we have a saner
implementation. The folloup is tracked at cockroachdb#40638.

Touches cockroachdb#40638.
Fixes cockroachdb#24136.

Release notes (bug fix): none.
@spaskob spaskob removed their assignment Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spaskob @mwang1026