-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity: failed tests on master: test/TestBackupRestoreControlJob #24136
Comments
haven't seen this one in 4 months |
That would be because it was skipped for those four months. :) https://github.com/cockroachdb/cockroach/blob/master/pkg/ccl/backupccl/backup_test.go#L858 |
The test was flaky and hence skipped for quite sometime. I wasn't able to fix it in it's current form because of the complexity of how we enable job control statements today. This will be revisited once we have a saner implementation. The folloup is tracked at cockroachdb#40638. Touches cockroachdb#40638. Fixes cockroachdb#24136. Release notes (bug fix): none.
The test was flaky and hence skipped for quite sometime. I wasn't able to fix it in it's current form because of the complexity of how we enable job control statements today. This will be revisited once we have a saner implementation. The folloup is tracked at cockroachdb#40638. Touches cockroachdb#40638. Fixes cockroachdb#24136. Release notes (bug fix): none.
This test is still skipped -- reopening https://github.com/cockroachdb/cockroach/blob/e450b31463f6c344918300f2a27d2947a80564e2/pkg/ccl/backupccl/backup_test.go#L1498 |
cc @cockroachdb/bulk-io |
Hi @shermanCRL, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
98792: kvserver: unskip `TestNewTruncateDecision` r=erikgrinaker a=erikgrinaker Passed after 10k stress runs. Has been skipped since 2019, issue seems to have been fixed in the meanwhile. Resolves #38584. Epic: none Release note: None 98855: roachtest: enable schema changes in acceptance/version-upgrade r=fqazi a=fqazi Previously, due to flakes we disabled schema changes inside the version update test. This patch re-enables them, since we are confident that the workload itslef is now stable in a mixed version state. Fixes: #58489 Release note: None 99023: kv: add log scope to BenchmarkSingleRoundtripWithLatency r=arulajmani a=nvanbenschoten Informs #98887. Avoids mixing logs with benchmark results, which breaks benchdiff. Release note: None 99033: storepool: set last unavailable on gossip dead r=andrewbaptist a=kvoli Previously, the `LastUnavailable` time was set in most parts of the storepool when a store was considered either `Unavailable`, `Dead`, `Decommissioned` or `Draining`. When `LastUnavailable` is within the last suspect duration (30s default), the node is treated as suspect by other nodes in the cluster. `LastUnavailable` was not being set when a store was considered dead due to the store not gossiping its store descriptor. This commit updates the `status` storepool function to do just that. Informs: #98928 Release note: None 99039: pkg/ccl/backupccl: Remove TestBackupRestoreControlJob r=benbardin a=benbardin This test has was marked skipped for flakiness, in 2018. Fixes: #24136 Release note: None Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Ben Bardin <[email protected]>
The following tests appear to have failed:
#581903:
Please assign, take a look and update the issue accordingly.
Jira issue: CRDB-13756
The text was updated successfully, but these errors were encountered: