-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Render graphs with D3 directly, replacing use of NVD3 #18620
Comments
I've broken down the major steps to replacing our use of NVD3 for the time series charts. This is where I'll be tracking the progress as I work on this:
|
This commit replaces our usage of NVD3 with a vanilla D3 implementation of the same charts. Closes cockroachdb#18620 and cockroachdb#18665 while we're at it. Depends on D3v4, and currently uses a different (read, simpler) API than our current charts, so can't (yet) actually be used on the dashboard.
This is the last major functionality NVD3 is giving us (besides the charts themselves). Replacing it with our own will enable future customization as well as make it easier to completely excise NVD3 at some point soon. Contributes to cockroachdb#18620. Release note: None
This is the last major functionality NVD3 is giving us (besides the charts themselves). Replacing it with our own will enable future customization as well as make it easier to completely excise NVD3 at some point soon. Contributes to cockroachdb#18620. Release note: None
This is the last major functionality NVD3 is giving us (besides the charts themselves). Replacing it with our own will enable future customization as well as make it easier to completely excise NVD3 at some point soon. Contributes to cockroachdb#18620. Release note: None
We have marked this issue as stale because it has been inactive for |
We have used the NVD3 library to draw our metrics graphs since the creation of the Admin UI. However, we are rapidly outgrowing the restraints of this system:
NVD3 is a library meant to provide a reasonable level of graph utility for a wide array of use cases; we now need a more advanced level of graph utility for a narrower use case. Therefore, we should begin rendering our graphs using D3 directly; this will afford us greater control and understanding of the rendering process, allowing us to debug issues more effectively and add advanced features more easily.
EDIT 2019: Related issues.
Features this will directly or indirectly enable:
Bugs this will likely obselete (let's not repeat them, though):
The text was updated successfully, but these errors were encountered: