-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: don't show decimal places for integral values #12973
Comments
@vivekmenezes I noticed you removed a couple of these admin UI ux clean-ups out of 1.0. Do you mind explaining your methodology behind it? I'm trying to assign a milestone for everything, so I'm moving these to 1.1. |
Moving out to 1.2 so that @mrtracy can focus on finishing up the final features for 1.1 |
I think this ticket should be generalized to cover all cases of using floats to display what are conceptually integers in the UI, e.g., ranges, etc. (Or does that issue exist somewhere? Sorry if so, this was what I found.) As a new user, I have been finding it confusing/distracting to see floats displayed in so many places since decimals imply a certain precision that isn't usually intended (I think? Related: "significant digits" from Chemistry class). My eye keeps "hanging up" on the decimals that end in |
To piggyback on Rich's comment, when we show floats on the Replicas per Store graph, that could be misinterpreted by users to mean that it's possible for a store to have only part of a replica, which I don't think is possible (perhaps except when a range is rebalancing). |
We have marked this issue as stale because it has been inactive for |
Steps to Repro
Expected Result
Because you cannot have partial nodes, the scaling of the values is represented only as integers.
Actual Result
The scale of number of nodes includes decimal values, insinuating that a partial node has some kind of meaning.
The text was updated successfully, but these errors were encountered: