Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: don't show decimal places for integral values #12973

Closed
sploiselle opened this issue Jan 18, 2017 · 5 comments
Closed

ui: don't show decimal places for integral values #12973

sploiselle opened this issue Jan 18, 2017 · 5 comments
Labels
A-webui-timeseries C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity X-stale

Comments

@sploiselle
Copy link
Contributor

Steps to Repro

  1. Create a 3-node cluster.
  2. Go to admin UI.
  3. View Node count graph.

Expected Result

Because you cannot have partial nodes, the scaling of the values is represented only as integers.

Actual Result

The scale of number of nodes includes decimal values, insinuating that a partial node has some kind of meaning.

screen shot 2017-01-18 at 12 41 27 pm

@sploiselle sploiselle added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Jan 18, 2017
@mrtracy mrtracy self-assigned this Jan 19, 2017
@petermattis petermattis changed the title UI: Node count represented as decimal when only int values possible ui: node count represented as decimal when only int values possible Feb 23, 2017
@petermattis petermattis added this to the 1.0 milestone Feb 23, 2017
@vivekmenezes vivekmenezes removed this from the 1.0 milestone Apr 11, 2017
@dianasaur323
Copy link
Contributor

@vivekmenezes I noticed you removed a couple of these admin UI ux clean-ups out of 1.0. Do you mind explaining your methodology behind it? I'm trying to assign a milestone for everything, so I'm moving these to 1.1.

@dianasaur323 dianasaur323 modified the milestones: 1.1, Later Apr 19, 2017
@petermattis petermattis modified the milestones: 1.1, Later Jun 1, 2017
@dianasaur323 dianasaur323 added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Jun 19, 2017
@dianasaur323
Copy link
Contributor

Moving out to 1.2 so that @mrtracy can focus on finishing up the final features for 1.1

@dianasaur323 dianasaur323 modified the milestones: 1.2, 1.1 Aug 16, 2017
@couchand couchand assigned couchand and unassigned mrtracy Oct 2, 2017
@couchand couchand modified the milestones: 2.0, Later Jan 29, 2018
@rmloveland
Copy link
Collaborator

rmloveland commented Mar 7, 2018

I think this ticket should be generalized to cover all cases of using floats to display what are conceptually integers in the UI, e.g., ranges, etc. (Or does that issue exist somewhere? Sorry if so, this was what I found.)

As a new user, I have been finding it confusing/distracting to see floats displayed in so many places since decimals imply a certain precision that isn't usually intended (I think? Related: "significant digits" from Chemistry class). My eye keeps "hanging up" on the decimals that end in .00 and really wants them to be integers, especially 0.000.

@jseldess
Copy link
Contributor

jseldess commented Mar 7, 2018

To piggyback on Rich's comment, when we show floats on the Replicas per Store graph, that could be misinterpreted by users to mean that it's possible for a store to have only part of a replica, which I don't think is possible (perhaps except when a range is rebalancing).

@couchand couchand changed the title ui: node count represented as decimal when only int values possible ui: don't show decimal place for integral values Mar 7, 2018
@couchand couchand changed the title ui: don't show decimal place for integral values ui: don't show decimal places for integral values Mar 7, 2018
@couchand couchand added A-webui-timeseries and removed S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. labels Apr 24, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webui-timeseries C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

8 participants