Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: TestClockOffsetInPingRequest failed #136703

Closed
cockroach-teamcity opened this issue Dec 4, 2024 · 0 comments · Fixed by #136849
Closed

rpc: TestClockOffsetInPingRequest failed #136703

cockroach-teamcity opened this issue Dec 4, 2024 · 0 comments · Fixed by #136849
Assignees
@andrewbaptist
Labels
branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 4, 2024 •
edited by cockroach-jira-scripts
Loading

rpc.TestClockOffsetInPingRequest failed with artifacts on release-24.3 @ 563905c072f3d74a969c959b8d29eb7f1408b04a:

=== RUN   TestClockOffsetInPingRequest
    context_test.go:223: server listen
    context_test.go:230: client dial
E241204 14:53:17.048972 407 2@rpc/peer.go:663  [rnode=1,raddr=127.0.0.1:37365,class=system,rpc] 10  failed connection attempt (last connected 0s ago): operation "conn heartbeat" timed out after 101ms (given timeout 100ms): grpc: context deadline exceeded [code 4/DeadlineExceeded]
I241204 14:53:17.057869 407 2@rpc/peer.go:589  [rnode=1,raddr=127.0.0.1:37365,class=system,rpc] 11  connection is now healthy (after 0s)
    context_test.go:244: first two pings check
    context_test.go:252: ping 1 check
    context_test.go:260: 
        	Error Trace:	pkg/rpc/context_test.go:260
        	            				pkg/rpc/context_test.go:175
        	Error:      	Should not be zero, but was 0
        	Test:       	TestClockOffsetInPingRequest
        	Messages:   	1
--- FAIL: TestClockOffsetInPingRequest (0.22s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-45206
@cockroach-teamcity cockroach-teamcity added branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Dec 4, 2024
@andrewbaptist andrewbaptist mentioned this issue Dec 5, 2024
Merged
@andrewbaptist andrewbaptist removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 5, 2024
@andrewbaptist andrewbaptist self-assigned this Dec 9, 2024
@andrewbaptist andrewbaptist added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Dec 9, 2024
craig bot pushed a commit that referenced this issue Dec 9, 2024
@andrewbaptist
Merge #136849
683618f 
136849: rpc: increase timeout for TestClockOffsetInPingRequest r=miraradeva a=andrewbaptist

Previously this test had the `RPCHeartbeatInterval` and `RPCHeartbeatTimeout` both set at 100ms. Normally the `RPCHeartbeatTimeout` is set at 3x the interval. During race builds this provides enough extra cushion that the test should pass.

Epic: none
Fixes: #136703

Release note: None

Co-authored-by: Andrew Baptist <[email protected]>
@craig craig bot closed this as completed in d0cd9ba Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbaptist andrewbaptist

Labels
branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: increase timeout for TestClockOffsetInPingRequest andrewbaptist/cockroach
2 participants
@cockroach-teamcity @andrewbaptist