rpc: increase timeout for TestClockOffsetInPingRequest #136849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this test had the `RPCHeartbeatInterval` and `RPCHeartbeatTimeout` both set at 100ms. Normally the `RPCHeartbeatTimeout` is set at 3x the interval. During race builds this provides enough extra cushion that the test should pass. Epic: none Fixes: cockroachdb#136703 Release note: None
|
This change is |
|
I wasn't able to reproduce this before or after the failure, but I think this change will make it much less flaky. I ran |
miraradeva
approved these changes
Dec 5, 2024
|
TFTR! bors r=miraradeva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test had the
RPCHeartbeatIntervalandRPCHeartbeatTimeoutboth set at 100ms. Normally theRPCHeartbeatTimeoutis set at 3x the interval. During race builds this provides enough extra cushion that the test should pass.Epic: none
Fixes: #136703
Release note: None