Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvclient/kvcoord: TestRangeFeedMetricsManagement failed #115407

Closed
cockroach-teamcity opened this issue Dec 1, 2023 · 5 comments
Closed

kv/kvclient/kvcoord: TestRangeFeedMetricsManagement failed #115407

cockroach-teamcity opened this issue Dec 1, 2023 · 5 comments
Assignees
@miretskiy
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 1, 2023 •
edited by rickystewart
Loading

kv/kvclient/kvcoord.TestRangeFeedMetricsManagement failed with artifacts on master @ 6d7d8415f112fc478779bf2868be2385237030da:

Previous write at 0x00c008b7da00 by goroutine 18760:
  github.com/cockroachdb/cockroach/pkg/util/span.(*frontierHeap).Push()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:692 +0x12c
  container/heap.Push()
      GOROOT/src/container/heap/heap.go:52 +0x45
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).setEntry()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:394 +0x16b
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).splitEntryAt()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:435 +0x3d7
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:512 +0xae4
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).Forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:300 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.4()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:702 +0x6c8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).singleRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:886 +0xf12
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:585 +0x790
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:272 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 18765 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 18760 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76
==================

Parameters: TAGS=bazel,gss , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/replication

This test on roachdash | Improve this report!

Jira issue: CRDB-34014
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv-replication labels Dec 1, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 1, 2023
@erikgrinaker
Copy link
Contributor

Data race from #110516:

WARNING: DATA RACE
Read at 0x00c008b7da00 by goroutine 18765:
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).Frontier()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:258 +0x185
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).Forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:299 +0x199
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.4()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:702 +0x6c8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).singleRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:886 +0xf12
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:585 +0x790
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:272 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Previous write at 0x00c008b7da00 by goroutine 18760:
  github.com/cockroachdb/cockroach/pkg/util/span.(*frontierHeap).Push()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:692 +0x12c
  container/heap.Push()
      GOROOT/src/container/heap/heap.go:52 +0x45
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).setEntry()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:394 +0x16b
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).splitEntryAt()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:435 +0x3d7
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:512 +0xae4
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).Forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:300 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.4()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:702 +0x6c8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).singleRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:886 +0xf12
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:585 +0x790
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:272 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

@erikgrinaker erikgrinaker removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 1, 2023
@miretskiy miretskiy added the P-1 Issues/test failures with a fix SLA of 1 month label Dec 1, 2023
@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestRangeFeedMetricsManagement failed with artifacts on master @ 74ae9a18d82fdc80e5e9b71b3f06b258ae5cb91b:

      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:653 +0x119
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).String()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:614 +0x22e
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.5()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:736 +0x5c
  github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1()
      github.com/cockroachdb/cockroach/pkg/testutils/soon.go:75 +0x57
  github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration()
      github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213 +0x158
  github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError()
      github.com/cockroachdb/cockroach/pkg/testutils/soon.go:81 +0xb2
  github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithin()
      github.com/cockroachdb/cockroach/pkg/testutils/soon.go:60 +0x69
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:734 +0x9f6
  github.com/cockroachdb/cockroach/pkg/testutils.RunValues[go.shape.*uint8,go.shape.bool].func1()
      github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28 +0x4f
  testing.tRunner()
      GOROOT/src/testing/testing.go:1595 +0x238
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1648 +0x44

Goroutine 21464 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 21404 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1648 +0x82a
  github.com/cockroachdb/cockroach/pkg/testutils.RunValues[go.shape.*uint8,go.shape.bool]()
      github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:27 +0xa2
  github.com/cockroachdb/cockroach/pkg/testutils.RunTrueAndFalse[go.shape.*uint8]()
      github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:19 +0x97
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:615 +0x6b9
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:593 +0x149
  testing.tRunner()
      GOROOT/src/testing/testing.go:1595 +0x238
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1648 +0x44
==================

Parameters: TAGS=bazel,gss , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestRangeFeedMetricsManagement failed with artifacts on master @ 74ae9a18d82fdc80e5e9b71b3f06b258ae5cb91b:

Previous write at 0x00c007ecf6e0 by goroutine 19033:
  github.com/cockroachdb/cockroach/pkg/util/span.(*frontierHeap).Push()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:692 +0x12c
  container/heap.Push()
      GOROOT/src/container/heap/heap.go:52 +0x45
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).setEntry()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:394 +0x16b
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).splitEntryAt()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:435 +0x3d7
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:512 +0xae4
  github.com/cockroachdb/cockroach/pkg/util/span.(*btreeFrontier).Forward()
      github.com/cockroachdb/cockroach/pkg/util/span/frontier.go:300 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.4()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:702 +0x6c8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).singleRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:886 +0xf12
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:585 +0x790
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:272 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 19038 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 19033 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76
==================

Parameters: TAGS=bazel,gss , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

kv/kvclient/kvcoord.TestRangeFeedMetricsManagement failed with artifacts on master @ 3797229f8951150426ff721d289ead52e063fb32:

      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Previous write at 0x00c009131150 by goroutine 20277:
  github.com/cockroachdb/cockroach/pkg/util/span.(*llrbFrontierHeap).Pop()
      github.com/cockroachdb/cockroach/pkg/util/span/llrb_frontier.go:90 +0xee
  container/heap.Remove()
      GOROOT/src/container/heap/heap.go:76 +0x9e
  github.com/cockroachdb/cockroach/pkg/util/span.(*llrbFrontier).insert()
      github.com/cockroachdb/cockroach/pkg/util/span/llrb_frontier.go:377 +0xb39
  github.com/cockroachdb/cockroach/pkg/util/span.(*llrbFrontier).Forward()
      github.com/cockroachdb/cockroach/pkg/util/span/llrb_frontier.go:194 +0x190
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test.TestRangeFeedMetricsManagement.func1.4()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord_test/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go:702 +0x6c8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).singleRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:886 +0xf12
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:585 +0x790
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:272 +0x2a4
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 20282 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76

Goroutine 20277 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x124
  github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:167 +0xa8
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1()
      github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:269 +0x5b2
  github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.Group.GoCtx.func3()
      github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x76
==================

Parameters: TAGS=bazel,gss , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@erikgrinaker erikgrinaker added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Dec 4, 2023
@andrew-delph
Copy link
Contributor

issue seems solved with: pr

./dev test pkg/kv/kvclient/kvcoord --stress --filter=TestRangeFeedMetricsManagement -- --define gotags=bazel,gss --nocache_test_results

@craig craig bot closed this as completed in 45fbd10 Dec 4, 2023
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Dec 4, 2023
kvcoord: Use concurrent frontier in test
188ae93 
Use concurrent frontier in TestRangeFeedMetricsManagement.

Fixes cockroachdb#115407

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miretskiy miretskiy

Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month
Projects
None yet
Milestone
24.1
Development

No branches or pull requests
4 participants
@erikgrinaker @andrew-delph @cockroach-teamcity @miretskiy