Metrics 'forward' button does not go to the latest point in time #112847
Assignees
Labels
A-observability-inf
branch-release-23.2
Used to mark GA and release blockers, technical advisories, and bugs for 23.2
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-23.2-scale-testing
issues found during 23.2 scale testing
O-testcluster
Issues found or occurred on a test cluster, i.e. a long-running internal cluster
Comments
smcvey
added
C-bug
|
Hi @smcvey, can you help us understand why was this tagged as a release blocker? TIA |
|
Hi @kevin-v-ngo. I'm following the process described in https://docs.google.com/document/d/15zIOxUb0G_cB6gbl4Q8gC3lM6yyt_qq5r7PBsPuiq7I/edit which determines that any issues raised are marked as release blocker. The author of the process is William Kulju, so he should be able to provide you with more insight. |
kevin-v-ngo
removed
the
release-blocker
|
@kevin-v-ngo More context: We're opening all issues as release blockers by default (to be consistent with what test-eng does when they open an issue for a failing test). However, it is up to the discretion of triage teams to remove that tag if they deem appropriate. |
koorosh
added a commit
to koorosh/cockroach
that referenced
this issue
Nov 3, 2023
Before, "Forward" button on Time selector component allowed to select next time window if there's enough space for full increment (ie with 10 min time window, it wasn't possible to move forward if current end time is less that Now() - 10min). It caused misalignment where Forward button became disabled even if there's some more data to display. This change handles this case and updates current time window to current time (executes the same logic as Now button). Resolves: cockroachdb#112847 Release note (ui change): Forward button on time selector allows to select latest available timewindow (the same as with "Now" button) Release justification: low risk, high benefit changes to existing functionality
craig bot
pushed a commit
that referenced
this issue
Nov 6, 2023
112954: ui: enable Forward button to set timewindow for latest NOW value r=koorosh a=koorosh Before, "Forward" button on Time selector component allowed to select next time window if there's enough space for full increment (ie with 10 min time window, it wasn't possible to move forward if current end time is less that Now() - 10min). It caused misalignment where Forward button became disabled even if there's some more data to display. This change handles this case and updates current time window to current time (executes the same logic as Now button). Resolves: #112847 Release note (ui change): Forward button on time selector allows to select latest available timewindow (the same as with "Now" button) Release justification: low risk, high benefit changes to existing functionality https://github.com/cockroachdb/cockroach/assets/3106437/00f50793-c327-4902-903b-868ea2000047 113827: build: add BranchReleaseSeries r=RaduBerinde a=RaduBerinde This change adds `build.BranchReleaseSeries()` which returns the major and minor in `version.txt`. This will be used to know the current release series when the latest `clusterversion` is not finalized. We also clean up the code a bit: we separate the variables that are overridden by Bazel, and we use a different variable for the testing override (to make things more clear). Epic: none Release note: None 113864: jobs: only force jobs.MaybeGenerateForcedRetryableError in 23.1 r=dt a=dt Broken into a couple commits for ease of review: 1) jobs: plumb cluster version to info table accessor This is a pure refactor to plumb a clusterversion.Handle to the info table accessor via all the call sites and wrapping structs/call trees; no behavior change, or usage of the plumbed cv, is added in this commit. 2) jobs: only force jobs.MaybeGenerateForcedRetryableError in 23.1 3) jobs: only store 23.1 debugging info after 23.1 upgrade Release note (bug fix): fixed a bug that could cause 23.1 nodes in clusters which had not finalized the 23.1 version upgrade to use excessive CPU retrying expected errors related to the incomplete upgrade state. Informs #113795. Co-authored-by: Andrii Vorobiov <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: David Taylor <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Nov 6, 2023
Before, "Forward" button on Time selector component allowed to select next time window if there's enough space for full increment (ie with 10 min time window, it wasn't possible to move forward if current end time is less that Now() - 10min). It caused misalignment where Forward button became disabled even if there's some more data to display. This change handles this case and updates current time window to current time (executes the same logic as Now button). Resolves: #112847 Release note (ui change): Forward button on time selector allows to select latest available timewindow (the same as with "Now" button) Release justification: low risk, high benefit changes to existing functionality
williamkulju
added
O-testcluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
In some circumstances, clicking the 'Forward' arrow button on the Metrics page doesn't take the user to the same point as the 'Now' button would.
To Reproduce
Expected behavior
You should be able to click forward to get to the latest graphs.
Additional data / screenshots
These are the back and forward buttons as mentioned above:
This is what happens after clicking Forward as much as possible:
And then after clicking Now, note the graphs change (they should've been the same):
Environment:
Additional context
Cosmetic/Usability.
Jira issue: CRDB-32638
The text was updated successfully, but these errors were encountered: