Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed (comparison overload not found (is, refcursor, refcursor)) #112365

Closed
cockroach-teamcity opened this issue Oct 14, 2023 · 0 comments · Fixed by #112725
Closed

roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed (comparison overload not found (is, refcursor, refcursor)) #112365

cockroach-teamcity opened this issue Oct 14, 2023 · 0 comments · Fixed by #112725
Assignees
@DrewKimball
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 14, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.sqlsmith/setup=tpcc/setting=ddl-nodrop failed with artifacts on master @ f2bfa2a140fa302e79c9d31b84b944a6ac5e98ce:

(sqlsmith.go:258).func3: error: pq: internal error: executing declarative schema change PostCommitPhase stage 7 of 7 with 2 ValidationType ops (rollback=false) for ALTER TABLE: validate check constraint: comparison overload not found (is, refcursor, refcursor)
stmt:
ALTER TABLE defaultdb.public.item
	ADD COLUMN
		col54
			REFCURSOR
			AS ((CASE WHEN true THEN e'!1\'\x0b8&\by\x1e':::REFCURSOR ELSE '&0Qy':::REFCURSOR END)) STORED
			NOT NULL;
test artifacts and logs in: /artifacts/sqlsmith/setup=tpcc/setting=ddl-nodrop/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-32372
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Oct 14, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Oct 14, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 14, 2023
@yuzefovich yuzefovich changed the title roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed (comparison overload not found (is, refcursor, refcursor)) Oct 16, 2023
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries Oct 16, 2023
@cockroach-teamcity cockroach-teamcity mentioned this issue Oct 17, 2023
Closed
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Oct 19, 2023
@DrewKimball
sql: disallow refcursor comparisons during type-checking
28a523b 
This patch adds back the comparison functions for the `REFCURSOR` data
type, since there are various points within the codebase where we rely
on their existence. Users are still not allowed to use the comparison
functions, but now this is checked during type-checking of the AST,
rather than at execution-time. This should avoid internal errors from
places in planning and execution that expect comparison overloads to
exist, but also maintains parity with postgres.

Fixes cockroachdb#112365
Fixes cockroachdb#112642
Fixes cockroachdb#112362
Fixes cockroachdb#112368

Release note: None
@DrewKimball DrewKimball mentioned this issue Oct 19, 2023
Merged
craig bot pushed a commit that referenced this issue Oct 23, 2023
@DrewKimball @maryliag @nvanbenschoten
Merge #112725 #112891 #112893
a3d5317 
112725: sql: disallow refcursor comparisons during type-checking r=DrewKimball a=DrewKimball

This patch adds back the comparison functions for the `REFCURSOR` data type, since there are various points within the codebase where we rely on their existence. Users are still not allowed to use the comparison functions, but now this is checked during type-checking of the AST, rather than at execution-time. This should avoid internal errors from places in planning and execution that expect comparison overloads to exist, but also maintains parity with postgres.

Fixes #112365
Fixes #112642
Fixes #112362
Fixes #112368

Release note: None

112891: sql: fix for crash with null elements on jsonb_array_to_string_array r=maryliag a=maryliag

Fixes #112829

The builtin `jsonb_array_to_string_array` was crashing, when it had `null` elements. This commit handles this case, removing them from the final array.

Release note: None

112893: kv: tolerate lock acquisition replay with writes in same batch r=arulajmani a=nvanbenschoten

Informs #112221.
Informs #112174.
Informs #112173.
Informs #111984.
Informs #111893.
Informs #111564.
Informs #111530.

This commit fixes the handling of replayed batches that contain a replicated lock acquisition and a later write to the same key. In such cases, the write at the higher sequence number should not be detected as an error during the replay. Instead, it should simply be ignored.

Release note: None

Co-authored-by: Drew Kimball <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 6c0823f Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Oct 23, 2023
@blathers-crl blathers-crl bot mentioned this issue Oct 23, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 23, 2023
@DrewKimball
sql: disallow refcursor comparisons during type-checking
f0f96f5 
This patch adds back the comparison functions for the `REFCURSOR` data
type, since there are various points within the codebase where we rely
on their existence. Users are still not allowed to use the comparison
functions, but now this is checked during type-checking of the AST,
rather than at execution-time. This should avoid internal errors from
places in planning and execution that expect comparison overloads to
exist, but also maintains parity with postgres.

Fixes #112365
Fixes #112642
Fixes #112362
Fixes #112368

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrewKimball DrewKimball

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

sql: disallow refcursor comparisons during type-checking DrewKimball/cockroach
2 participants
@cockroach-teamcity @DrewKimball