-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql/tests: TestRandomSyntaxSQLSmith failed [comparison overload not found (eq, refcursor, refcursor)] #112362
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
O-rsg
Random Syntax Generator
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-sql-queries
SQL Queries Team
Milestone
Comments
cockroach-teamcity
added
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
labels
Oct 14, 2023
rafiss
changed the title
sql/tests: TestRandomSyntaxSQLSmith failed
sql/tests: TestRandomSyntaxSQLSmith failed [comparison overload not found (eq, refcursor, refcursor)]
Oct 16, 2023
rafiss
added
O-rsg
Random Syntax Generator
T-sql-queries
SQL Queries Team
and removed
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
labels
Oct 16, 2023
DrewKimball
added a commit
to DrewKimball/cockroach
that referenced
this issue
Oct 19, 2023
This patch adds back the comparison functions for the `REFCURSOR` data type, since there are various points within the codebase where we rely on their existence. Users are still not allowed to use the comparison functions, but now this is checked during type-checking of the AST, rather than at execution-time. This should avoid internal errors from places in planning and execution that expect comparison overloads to exist, but also maintains parity with postgres. Fixes cockroachdb#112365 Fixes cockroachdb#112642 Fixes cockroachdb#112362 Fixes cockroachdb#112368 Release note: None
This was referenced Oct 19, 2023
craig bot
pushed a commit
that referenced
this issue
Oct 23, 2023
112725: sql: disallow refcursor comparisons during type-checking r=DrewKimball a=DrewKimball This patch adds back the comparison functions for the `REFCURSOR` data type, since there are various points within the codebase where we rely on their existence. Users are still not allowed to use the comparison functions, but now this is checked during type-checking of the AST, rather than at execution-time. This should avoid internal errors from places in planning and execution that expect comparison overloads to exist, but also maintains parity with postgres. Fixes #112365 Fixes #112642 Fixes #112362 Fixes #112368 Release note: None 112891: sql: fix for crash with null elements on jsonb_array_to_string_array r=maryliag a=maryliag Fixes #112829 The builtin `jsonb_array_to_string_array` was crashing, when it had `null` elements. This commit handles this case, removing them from the final array. Release note: None 112893: kv: tolerate lock acquisition replay with writes in same batch r=arulajmani a=nvanbenschoten Informs #112221. Informs #112174. Informs #112173. Informs #111984. Informs #111893. Informs #111564. Informs #111530. This commit fixes the handling of replayed batches that contain a replicated lock acquisition and a later write to the same key. In such cases, the write at the higher sequence number should not be detected as an error during the replay. Instead, it should simply be ignored. Release note: None Co-authored-by: Drew Kimball <[email protected]> Co-authored-by: maryliag <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Oct 23, 2023
This patch adds back the comparison functions for the `REFCURSOR` data type, since there are various points within the codebase where we rely on their existence. Users are still not allowed to use the comparison functions, but now this is checked during type-checking of the AST, rather than at execution-time. This should avoid internal errors from places in planning and execution that expect comparison overloads to exist, but also maintains parity with postgres. Fixes #112365 Fixes #112642 Fixes #112362 Fixes #112368 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
O-rsg
Random Syntax Generator
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-sql-queries
SQL Queries Team
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ f2bfa2a140fa302e79c9d31b84b944a6ac5e98ce:
Random syntax error:
Query:
Schema:
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-32369
The text was updated successfully, but these errors were encountered: