Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test: TestTenantAutoUpgrade failed #112158

Closed
cockroach-teamcity opened this issue Oct 11, 2023 · 2 comments · Fixed by #112532
Closed

pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test: TestTenantAutoUpgrade failed #112158

cockroach-teamcity opened this issue Oct 11, 2023 · 2 comments · Fixed by #112532
Assignees
@ajstorm
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-multitenant Issues owned by the multi-tenant virtual team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 11, 2023 •
edited by cockroach-jira-scripts
Loading

pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test.TestTenantAutoUpgrade failed with artifacts on master @ 5af56c0ecd701d452c19fb89908012294b5336aa:

=== RUN   TestTenantAutoUpgrade
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade1757179939
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_upgrade_test.go:247: failed to receive the right auto upgrade status after 20 seconds
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade1757179939
--- FAIL: TestTenantAutoUpgrade (42.55s)

Parameters: TAGS=bazel,gss,deadlock , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/multi-tenant

This test on roachdash | Improve this report!

Jira issue: CRDB-32262
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-multitenant Issues owned by the multi-tenant virtual team labels Oct 11, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Oct 11, 2023
@cockroach-teamcity cockroach-teamcity mentioned this issue Oct 11, 2023
Closed
@cockroach-teamcity
Copy link
Member Author

pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test.TestTenantAutoUpgrade failed with artifacts on master @ 619aa6edad0269f75d12cb7d4b88b52f09825c7b:

=== RUN   TestTenantAutoUpgrade
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade2658169137
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_upgrade_test.go:247: failed to receive the right auto upgrade status after 20 seconds
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade2658169137
--- FAIL: TestTenantAutoUpgrade (43.11s)

Parameters: TAGS=bazel,gss,deadlock , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

pkg/ccl/kvccl/kvtenantccl/upgradeccl/upgradeccl_test.TestTenantAutoUpgrade failed with artifacts on master @ f2bfa2a140fa302e79c9d31b84b944a6ac5e98ce:

=== RUN   TestTenantAutoUpgrade
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade1059646552
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_upgrade_test.go:247: failed to receive the right auto upgrade status after 20 seconds
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/3a7f184254b17b9b5453b7560bf3e9f2/logTestTenantAutoUpgrade1059646552
--- FAIL: TestTenantAutoUpgrade (43.02s)

Parameters: TAGS=bazel,gss,deadlock , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ajstorm ajstorm self-assigned this Oct 16, 2023
@ajstorm ajstorm mentioned this issue Oct 17, 2023
Merged
craig bot pushed a commit that referenced this issue Oct 17, 2023
@yuzefovich @ajstorm @msbutler
Merge #112470 #112496 #112532 #112543
58957a2 
112470: upgrades: make stmt diag upgrade idempotent r=yuzefovich a=yuzefovich

All upgrades are expected to be idempotent, but the stmt diag upgrade (needed for plan-gist batched matching) wasn't - we needed to add `IF EXISTS` clause to the `DROP INDEX` stmt (which doesn't have a meaningful `schemaExistsFn`). Additionally, we can combine two stmts that add a single column into one that adds two.

Epic: None

Release note: None

112496: roachtest: use tpch workload in import-cancellation r=yuzefovich a=yuzefovich

Previously, we were using `querybench` to run TPCH queries after the import succeeded. The comments around the code suggest that we wanted to assert that the correct results were obtained, meaning that there was no data corruption during cancelled imports. However, `querybench` doesn't do any kind of verification, so this commit switches to using `tpch` workload with `--enable-checks=true` which does the desired verification.

Noticed this when looking at #111985.

Epic: None

Release note: None

112532: upgrade: Increase timeout for TestTenantAutoUpgrade under stress r=stevendanna a=ajstorm

Test times out under stress. With updated timeout it now passes on a local repro.

Fixes: #112158

Release note: None

112543: streamingccl: unskip TestStreamingRegionalConstraint r=kvoli a=msbutler

This patch unskips TestStreamingRegionalConstraint under a non-stress build.

Fixes #111541

Release note: none

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Adam Storm <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in d59fa1c Oct 17, 2023
@ajstorm ajstorm mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajstorm ajstorm

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

upgrade: Increase timeout for TestTenantAutoUpgrade under stress ajstorm/cockroach
2 participants
@ajstorm @cockroach-teamcity