Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: import-cancellation failed #111985

Closed
cockroach-teamcity opened this issue Oct 7, 2023 · 3 comments · Fixed by #112566
Closed

roachtest: import-cancellation failed #111985

cockroach-teamcity opened this issue Oct 7, 2023 · 3 comments · Fixed by #112566
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 7, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.import-cancellation failed with artifacts on master @ 3b438b4a59ad4759e5bf22ff0b6dd6e678c2be0d:

(test_runner.go:1150).runTest: test timed out (4h0m0s)
(import_cancellation.go:168).func2: full command output in run_104712.534899316_n1_workload-run-querybe.log: COMMAND_PROBLEM: exit status 134
(monitor.go:153).Wait: monitor failure: monitor user task failed: t.Fatal() was called
test artifacts and logs in: /artifacts/import-cancellation/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=32 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-32169
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Oct 7, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Oct 7, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 7, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.import-cancellation failed with artifacts on master @ 3b438b4a59ad4759e5bf22ff0b6dd6e678c2be0d:

(test_runner.go:1150).runTest: test timed out (4h0m0s)
(import_cancellation.go:308).runImportSequence: dial tcp 35.196.249.109:26257: connect: connection refused
(import_cancellation.go:148).runImportCancellation: context canceled
test artifacts and logs in: /artifacts/import-cancellation/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=32 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

@yuzefovich yuzefovich mentioned this issue Oct 17, 2023
Merged
@yuzefovich
Copy link
Member

Both of these failures are on Collect Coverage Roachtest Nightly CI target. I'm assuming that this target is expected to be slower, right @RaduBerinde? Perhaps we need to introduce "coverage-specific" timeouts that are longer than in the vanilla runs?

@RaduBerinde
Copy link
Member

If it's only on coverage runs, we can remove the release_blocker label. Note that these don't run automatically yet.

From what I know, it's supposed to be 5-10% slower.. I think we should just make the timeout bigger in all cases.

craig bot pushed a commit that referenced this issue Oct 17, 2023
@yuzefovich @ajstorm @msbutler
Merge #112470 #112496 #112532 #112543
58957a2 
112470: upgrades: make stmt diag upgrade idempotent r=yuzefovich a=yuzefovich

All upgrades are expected to be idempotent, but the stmt diag upgrade (needed for plan-gist batched matching) wasn't - we needed to add `IF EXISTS` clause to the `DROP INDEX` stmt (which doesn't have a meaningful `schemaExistsFn`). Additionally, we can combine two stmts that add a single column into one that adds two.

Epic: None

Release note: None

112496: roachtest: use tpch workload in import-cancellation r=yuzefovich a=yuzefovich

Previously, we were using `querybench` to run TPCH queries after the import succeeded. The comments around the code suggest that we wanted to assert that the correct results were obtained, meaning that there was no data corruption during cancelled imports. However, `querybench` doesn't do any kind of verification, so this commit switches to using `tpch` workload with `--enable-checks=true` which does the desired verification.

Noticed this when looking at #111985.

Epic: None

Release note: None

112532: upgrade: Increase timeout for TestTenantAutoUpgrade under stress r=stevendanna a=ajstorm

Test times out under stress. With updated timeout it now passes on a local repro.

Fixes: #112158

Release note: None

112543: streamingccl: unskip TestStreamingRegionalConstraint r=kvoli a=msbutler

This patch unskips TestStreamingRegionalConstraint under a non-stress build.

Fixes #111541

Release note: none

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Adam Storm <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
This was referenced Oct 17, 2023
Closed
Closed
@yuzefovich yuzefovich mentioned this issue Oct 17, 2023
Merged
@craig craig bot closed this as completed in b8c9297 Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

roachtest: bump import-cancellation timeout from 4h to 6h yuzefovich/cockroach
3 participants
@yuzefovich @RaduBerinde @cockroach-teamcity