Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRandomSyntaxSQLSmith missing lib geos #109986

Closed
cockroach-teamcity opened this issue Sep 4, 2023 · 4 comments
Closed

TestRandomSyntaxSQLSmith missing lib geos #109986

cockroach-teamcity opened this issue Sep 4, 2023 · 4 comments
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 4, 2023 •
edited by cockroach-jira-scripts
Loading

sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on release-23.1 @ fde98bbb2423906a7e3bfd9cd7956bc3f29918ad:

	panic: geos: no locations to init GEOS [recovered]
	panic: geos: no locations to init GEOS

goroutine 8888992 [running]:
testing.tRunner.func1.2({0x58cb460, 0xc0349d6e60})
	GOROOT/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	GOROOT/src/testing/testing.go:1399 +0x39f
panic({0x58cb460, 0xc0349d6e60})
	GOROOT/src/runtime/panic.go:884 +0x212
github.com/cockroachdb/cockroach/pkg/util/leaktest.AfterTest.func2()
	github.com/cockroachdb/cockroach/pkg/util/leaktest/leaktest.go:133 +0x2f5
panic({0x58cb460, 0xc0349d6e60})
	GOROOT/src/runtime/panic.go:884 +0x212
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover(0x74ec2b8?, {0x74a1470, 0xc0000c2048})
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:229 +0x6a
panic({0x58cb460, 0xc0349d6e60})
	GOROOT/src/runtime/panic.go:884 +0x212
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).Stop(0xc0343ccc80, {0x74a1470, 0xc0000c2048})
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:507 +0x1dd
panic({0x58cb460, 0xc0349d6e60})
	GOROOT/src/runtime/panic.go:884 +0x212
github.com/cockroachdb/cockroach/pkg/sql/randgen.encodeInvertedIndexHistogramUpperBounds(0xa5f15a0?, {0x750c200?, 0xc035339f50?})
	github.com/cockroachdb/cockroach/pkg/sql/randgen/mutator.go:377 +0x445
github.com/cockroachdb/cockroach/pkg/sql/randgen.randHistogram(0x745dfe0?, 0xa5f15a0)
	github.com/cockroachdb/cockroach/pkg/sql/randgen/mutator.go:310 +0x13c
github.com/cockroachdb/cockroach/pkg/sql/randgen.statisticsMutator.func1(0xc064a31b00)
	github.com/cockroachdb/cockroach/pkg/sql/randgen/mutator.go:227 +0x96
github.com/cockroachdb/cockroach/pkg/sql/randgen.statisticsMutator(0xc01edc53e0, {0xc0645c7b00?, 0x4, 0xc01edc53e0?})
	github.com/cockroachdb/cockroach/pkg/sql/randgen/mutator.go:260 +0x71f
github.com/cockroachdb/cockroach/pkg/sql/randgen.MultiStatementMutation.Mutate(0xc060b3ca10?, 0x5e7072e?, {0xc0645c7b00?, 0x5392da0?, 0x1?})
	github.com/cockroachdb/cockroach/pkg/sql/randgen/mutator.go:98 +0x2e
github.com/cockroachdb/cockroach/pkg/sql/randgen.RandCreateTables(0x5392da0?, {0x5e7072e, 0x5}, 0x4, 0x60?, {0xc060b3caf0, 0x3, 0xa400000000000000?})
	github.com/cockroachdb/cockroach/pkg/sql/randgen/schema.go:93 +0x16a
github.com/cockroachdb/cockroach/pkg/internal/sqlsmith.randTablesN(0x41?, 0xc060b3cb80?, {0x0, 0x0})
	github.com/cockroachdb/cockroach/pkg/internal/sqlsmith/setup.go:104 +0x194
github.com/cockroachdb/cockroach/pkg/internal/sqlsmith.randTables(0xc060b3cc98?)
	github.com/cockroachdb/cockroach/pkg/internal/sqlsmith/setup.go:84 +0x37
github.com/cockroachdb/cockroach/pkg/internal/sqlsmith.wrapCommonSetup.func1(0x554e9a0?)
	github.com/cockroachdb/cockroach/pkg/internal/sqlsmith/setup.go:51 +0x22
github.com/cockroachdb/cockroach/pkg/sql/tests_test.TestRandomSyntaxSQLSmith.func1({0x74a1470, 0xc0000c2048}, 0xc061fdf480, 0xc05e728820)
	github.com/cockroachdb/cockroach/pkg/sql/tests_test/pkg/sql/tests/rsg_test.go:658 +0x157
github.com/cockroachdb/cockroach/pkg/sql/tests_test.testRandomSyntax(0xc0343c89c0, 0xc0?, {0x5e87281, 0x9}, 0xc060b3df28, 0xc02d4b2ca8)
	github.com/cockroachdb/cockroach/pkg/sql/tests_test/pkg/sql/tests/rsg_test.go:834 +0x6b9
github.com/cockroachdb/cockroach/pkg/sql/tests_test.TestRandomSyntaxSQLSmith(0xc0343c89c0)
	github.com/cockroachdb/cockroach/pkg/sql/tests_test/pkg/sql/tests/rsg_test.go:652 +0x212
testing.tRunner(0xc0343c89c0, 0x6250110)
	GOROOT/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	GOROOT/src/testing/testing.go:1493 +0x35f
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-31202
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Sep 4, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Sep 4, 2023
@rafiss
Copy link
Collaborator

rafiss commented Sep 5, 2023

This seems related to encodeInvertedIndexHistogramUpperBounds in randgen, so tagging SQL Queries.

@rafiss rafiss added T-sql-queries SQL Queries Team O-rsg Random Syntax Generator and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Sep 5, 2023
@rharding6373
Copy link
Collaborator

Looks like a test is missing a link to lib geos, similar to #104700.

@rharding6373 rharding6373 changed the title sql/tests: TestRandomSyntaxSQLSmith failed TestRandomSyntaxSQLSmith missing lib geos Sep 5, 2023
herkolategan added a commit to herkolategan/cockroach that referenced this issue Sep 6, 2023
@herkolategan
build: add cdeps to random syntax tests
7d36f76 
Previously a failure occurred on these tests where it required libgeos. This
change adds a build step to ensure that libgeos is in the bazel-bin dirs. This
should fix the dependency issue.

Refs: cockroachdb#109986

Epic: None
Release note: None
@herkolategan herkolategan mentioned this issue Sep 6, 2023
Merged
@rharding6373
Copy link
Collaborator

Unable to repro this failure due to lack of determinism in this test, which will be fixed by #110127. Herko has a potential fix in #110129. Closing this issue now.

@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Sep 6, 2023
craig bot pushed a commit that referenced this issue Sep 7, 2023
@herkolategan
Merge #110129
23ba611 
110129: build: add cdeps to random syntax tests r=rharding6373 a=herkolategan

Previously a failure occurred on these tests where it required libgeos. This change adds a build step to ensure that libgeos is in the bazel-bin dirs. This should fix the dependency issue.

Refs: #109986

Epic: None
Release note: None

Co-authored-by: Herko Lategan <[email protected]>
herkolategan added a commit to herkolategan/cockroach that referenced this issue Sep 7, 2023
@herkolategan
build: add cdeps to random syntax tests
be0bb2c 
Previously a failure occurred on these tests where it required libgeos. This
change adds a build step to ensure that libgeos is in the bazel-bin dirs. This
should fix the dependency issue.

Refs: cockroachdb#109986

Epic: None
Release note: None
@herkolategan herkolategan mentioned this issue Sep 7, 2023
Merged
herkolategan added a commit to herkolategan/cockroach that referenced this issue Sep 7, 2023
@herkolategan
build: add cdeps to random syntax tests
db08f2b 
Previously a failure occurred on these tests where it required libgeos. This
change adds a build step to ensure that libgeos is in the bazel-bin dirs. This
should fix the dependency issue.

Refs: cockroachdb#109986

Epic: None
Release note: None
@herkolategan herkolategan mentioned this issue Sep 7, 2023
Merged
@exalate-issue-sync exalate-issue-sync bot reopened this Sep 13, 2023
@github-project-automation github-project-automation bot moved this from Done to Triage in SQL Queries Sep 13, 2023
@celiala
Copy link
Collaborator

celiala commented Sep 13, 2023

sorry - the exalate re-open was me - closing.

@celiala celiala closed this as completed Sep 13, 2023
@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
SQL Foundations
Archived in project
Milestone
23.1
Development

No branches or pull requests
4 participants
@rafiss @celiala @rharding6373 @cockroach-teamcity