build: add cdeps to random syntax tests #110129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a failure occurred on these tests where it required libgeos. This change adds a build step to ensure that libgeos is in the bazel-bin dirs. This should fix the dependency issue. Refs: cockroachdb#109986 Epic: None Release note: None
|
This change is |
herkolategan
commented
Sep 6, 2023
There was a problem hiding this comment.
TC sanity check: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RandomSyntaxTestsBazel/11657199
Reviewable status:
complete! 0 of 0 LGTMs obtained
rharding6373
approved these changes
Sep 6, 2023
|
TFTR! |
|
Build succeeded: |
This was referenced Sep 7, 2023
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Sep 19, 2023
In [1], we updated CI (nightly) to require a build step for `//c-deps:libgeos`. That didn't fix `rsg_test`'s implicit dependency on libgeos, since the produced artifacts are not reachable from the test sandbox. Instead, we use a runfile dependency--same way other test packages specify libgeos dependency. This enables dynamic loading via `bazel.Runfile`. [1] cockroachdb#110129 Epic: none Fixes: cockroachdb#110780 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
110850: codeowners: add `test-eng-prs` to `pkg/clusterversion` r=healthy-pod a=healthy-pod part of: DEVINF-509 Release note: None 110926: sql: add libgeos runfile dependency for RSG tests r=rickystewart,herkolategan a=srosenberg In [1], we updated CI (nightly) to require a build step for `//c-deps:libgeos`. That didn't fix `rsg_test`'s implicit dependency on libgeos, since the produced artifacts are not reachable from the test sandbox. Instead, we use a runfile dependency--same way other test packages specify libgeos dependency. This enables dynamic loading via `bazel.Runfile`. [1] #110129 Epic: none Fixes: #110780 Release note: None Co-authored-by: healthy-pod <[email protected]> Co-authored-by: Stan Rosenberg <[email protected]>
This was referenced Sep 20, 2023
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Sep 20, 2023
In [1], we updated CI (nightly) to require a build step for `//c-deps:libgeos`. That didn't fix `rsg_test`'s implicit dependency on libgeos, since the produced artifacts are not reachable from the test sandbox. Instead, we use a runfile dependency--same way other test packages specify libgeos dependency. This enables dynamic loading via `bazel.Runfile`. [1] cockroachdb#110129 Epic: none Fixes: cockroachdb#110780 Release note: None
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Sep 20, 2023
In [1], we updated CI (nightly) to require a build step for `//c-deps:libgeos`. That didn't fix `rsg_test`'s implicit dependency on libgeos, since the produced artifacts are not reachable from the test sandbox. Instead, we use a runfile dependency--same way other test packages specify libgeos dependency. This enables dynamic loading via `bazel.Runfile`. [1] cockroachdb#110129 Epic: none Fixes: cockroachdb#110780 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a failure occurred on these tests where it required libgeos. This change adds a build step to ensure that libgeos is in the bazel-bin dirs. This should fix the dependency issue.
Refs: #109986
Epic: None
Release note: None