Merge #97358

97358: kvserver: disable overeager slow lease warning r=erikgrinaker a=tbg Touches #97209. Epic: none Release note (bug fix): the following spammy log message was removed: > lease [...] expired before being followed by lease [...]; foreground traffic may have been impacted Co-authored-by: Tobias Grieger <[email protected]>
cockroachdb · Feb 20, 2023 · 8124f66 · 8124f66
2 parents 03b3159 + baf3469
commit 8124f66
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/kv/kvserver/replica_proposal.go b/pkg/kv/kvserver/replica_proposal.go
@@ -370,7 +370,8 @@ func (r *Replica) leasePostApplyLocked(
 
 	// NB: ProposedTS is non-nil in practice, but we never fully migrated it
 	// in so we need to assume that it can be nil.
-	if iAmTheLeaseHolder && leaseChangingHands && newLease.ProposedTS != nil {
+	const slowLeaseWarningEnabled = false // see https://github.com/cockroachdb/cockroach/issues/97209
+	if slowLeaseWarningEnabled && iAmTheLeaseHolder && leaseChangingHands && newLease.ProposedTS != nil {
 		maybeLogSlowLeaseApplyWarning(ctx, time.Duration(now.WallTime-newLease.ProposedTS.WallTime), prevLease, newLease)
 	}