Skip to content

Commit

Permalink
kvserver: disable overeager slow lease warning
Browse files Browse the repository at this point in the history
Epic: none
Release note (bug fix): the following spammy log message was removed:
> lease [...] expired before being followed by lease [...]; foreground traffic may have been impacted
  • Loading branch information
tbg committed Feb 20, 2023
1 parent a9d4e70 commit baf3469
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/kv/kvserver/replica_proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ func (r *Replica) leasePostApplyLocked(

// NB: ProposedTS is non-nil in practice, but we never fully migrated it
// in so we need to assume that it can be nil.
if iAmTheLeaseHolder && leaseChangingHands && newLease.ProposedTS != nil {
const slowLeaseWarningEnabled = false // see https://github.com/cockroachdb/cockroach/issues/97209
if slowLeaseWarningEnabled && iAmTheLeaseHolder && leaseChangingHands && newLease.ProposedTS != nil {
maybeLogSlowLeaseApplyWarning(ctx, time.Duration(now.WallTime-newLease.ProposedTS.WallTime), prevLease, newLease)
}

Expand Down

0 comments on commit baf3469

Please sign in to comment.