Skip to content

Commit

Permalink
Merge #98442
Browse files Browse the repository at this point in the history
98442: sql_test: unskip TestShowTraceReplica r=msirek a=msirek

Testing TestShowTraceReplica under stress and race no longer fails, so this test is unskipped.

To test:
```
./dev test pkg/sql --filter TestShowTraceReplica --stress --race --test-args "TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m'"
```

Fixes: #34213

Release note: None

Co-authored-by: Mark Sirek <[email protected]>
  • Loading branch information
craig[bot] and Mark Sirek committed Mar 14, 2023
2 parents 10c1e3e + cc650e7 commit 4215b86
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/sql/show_trace_replica_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/server"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/testutils/testcluster"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
Expand All @@ -34,8 +33,6 @@ func TestShowTraceReplica(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.WithIssue(t, 34213)

const numNodes = 4

zoneConfig := zonepb.DefaultZoneConfig()
Expand Down

0 comments on commit 4215b86

Please sign in to comment.