Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing multiple file permissions #850

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow editing multiple file permissions #850

wants to merge 2 commits into from

Commits on Nov 29, 2024

  1. Refactor the permissions dialog for multiple files editing 

    This refactors the EditPermissionsModal with the goal to no longer
accept `FolderFileInfo | null` and moving the special current working
directory logic into `menu.tsx`.

With these changes we can simplify the permissions dialog and open up
support for editing multiple files. Coincidentally this adds a
workaround for a bug where `basename("/")` return "".
    @jelly
    jelly committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    e0a8360 View commit details
    Browse the repository at this point in the history

  2. Allow changing permissions of multiple files 

    For our upload file(s) as administrator feature we want an easy way to
change permissions of multiple uploaded file(s). Editing multiple files
is restricted to regular files to not mix folder and file permissions
operations which might imply that all files under the folder change or
not.

Furthermore when the owner/group do not match it is not shown nor is the
SELinux context shown for the files as it is impossible to find a common
context.
    @jelly
    jelly committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8966d23 View commit details
    Browse the repository at this point in the history