Allow editing multiple file permissions #850
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the EditPermissionsModal with the goal to no longer
accept `FolderFileInfo | null` and moving the special current working
directory logic into `menu.tsx`.
With these changes we can simplify the permissions dialog and open up
support for editing multiple files. Coincidentally this adds a
workaround for a bug where `basename("/")` return "".
For our upload file(s) as administrator feature we want an easy way to change permissions of multiple uploaded file(s). Editing multiple files is restricted to regular files to not mix folder and file permissions operations which might imply that all files under the folder change or not. Furthermore when the owner/group do not match it is not shown nor is the SELinux context shown for the files as it is impossible to find a common context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked:
As discussed on Thursday, for multiple file uploads we want to allow users to change multiple file(s) permissions to be changed. This has been implemented with the following restrictions:
The title might need some UX but as of now it just concatenates multiple files in the title. This can be improved