Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @jx3box #325

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: add @jx3box #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2312f70
fix: README描述
X3ZvaWQ Nov 18, 2024
c04cf57
feat: add @jx3box
X3ZvaWQ Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ _你将会看到 package.json 文件中的 `allowPackages` 字段被更新，如
npm run add -- --scope=@eggjs
```

_你将会看到 package.json 文件中的 `allowPackages` 字段被更新，如下所示：_
_你将会看到 package.json 文件中的 `allowScopes` 字段被更新，如下所示：_
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Documentation needs additional updates for consistency

The documentation still contains another instance of allowPackages that should be updated to maintain consistency with the codebase. Based on the test file and the changes, both allowPackages and allowScopes are valid but separate configuration fields serving different purposes:

  • allowScopes is for allowing entire scopes (e.g., @babel)
  • allowPackages is for allowing specific packages with version constraints

The current documentation should be reviewed to ensure it correctly distinguishes between these two fields and their purposes.

🔗 Analysis chain

Documentation fix looks good!

The update correctly references the allowScopes field instead of allowPackages when describing how to add scoped packages.

Let's verify if there are any other instances of allowPackages that might need similar updates:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining incorrect references to allowPackages in the context of scoped packages
rg -i "allowpackages.*scope"

Length of output: 175

Script:

#!/bin/bash
# Let's check the content of test/index.js to understand the context
cat test/index.js

Length of output: 2557

Script:

#!/bin/bash
# Let's check the README.md content to see if there are any other instances of allowPackages
rg -i "allowpackages" README.md

Length of output: 104


```json
"allowScopes": [
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
"@js-preview",
"@jscpd",
"@jupyterlab",
"@jx3box",
"@kne",
"@kne-components",
"@koa",
Expand Down
Loading