corrected handling of showing help dialog contents on startup. #265
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use cross-browser css 'calc' so sidebar collapse arrows are correctly positioned in all browsers. Tested with Chrome, Firefox, IE8/11, Android def browser and iOS Safari.
DavidSpriggs
added a commit
that referenced
this pull request
Oct 28, 2014
corrected handling of showing help dialog contents on startup.
|
When making these changes in order to launch the Help Dialog on startup, it appears there is still one issue. The Help Dialog loads properly when the page loads; however, if the user closes the Help Dialog and resizes the browser window and then attempts to open the Help again, the Help Dialog will not render the tabs or content (only renders the title bar content). If the user then changes the browser window size with the Help Dialog open, all content will appear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use cross-browser css 'calc' so sidebar collapse arrows are correctly
positioned in all browsers.
Tested with Chrome, Firefox, IE8/11, Android def browser and iOS Safari.