Skip to content

Commit

Permalink
corrected handling of showing help dialog contents on startup.
Browse files Browse the repository at this point in the history 
use cross-browser css 'calc' so sidebar collapse arrows are correctly
positioned in all browsers.
Tested with Chrome, Firefox, IE8/11, Android def browser and iOS Safari.
  • Loading branch information
@tmcgee
tmcgee committed Oct 28, 2014
1 parent 4f020d3 commit 6e6881e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
8 changes: 8 additions & 0 deletions viewer/css/main.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,21 @@ body, html {
.sidebarCollapseButtonHorz {
width: 16px;
height: 25px;
top: 48%;
top: -webkit-calc(50% - 12px);
top: -moz-calc(50% - 12px);
top: -o-calc(50% - 12px);
top: calc(50% - 12px);
border-bottom: 1px solid #B5BCC7;
border-top: 1px solid #B5BCC7;
}
.sidebarCollapseButtonVert {
width: 25px;
height: 18px;
left: 48%;
left: -webkit-calc(50% - 12px);
left: -moz-calc(50% - 12px);
left: -o-calc(50% - 12px);
left: calc(50% - 12px);
border-left: 1px solid #B5BCC7;
border-right: 1px solid #B5BCC7;
Expand Down
6 changes: 4 additions & 2 deletions viewer/js/gis/dijit/Help.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ define([
on(help, 'click', lang.hitch(this.parentWidget, 'show'));
}
},
onShow: function () {
onOpen: function () {
// Make sure the content is visible when the dialog
// is shown/opened. Something like this may be needed
// for all floating windows that don't open on startup?
this.containerNode.resize();
if (!this.openOnStartup) {
this.containerNode.resize();
}
},
close: function () {
if (this.parentWidget.hide) {
Expand Down

5 comments on commit 6e6881e

@cmccullough2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to edit the Help widget. However, everytime I edit the HelpDialog.html file no changes are reflected. How can I update this widget?

@tr3vorm
Copy link
Contributor

@tr3vorm tr3vorm commented on 6e6881e Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccullough2 without knowing what it is you want to change exactly, possibly the page you are editing is being cached and you just need to clear the browser cache. Also, you should raise this as a new "Issue" instead of commenting here.

@wmedernach
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken I previously ran into this and it was the browser cache that was causing me grief.

@cmccullough2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to Add an AccordianController within the tab. I will try the cache. I did not do that. I am in the practice of doing it for Flex, but not JavaScript. Also if I am still having trouble I will start a new issue. Thanks

@cmccullough2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the cache. I was not expecting to do this.

Please sign in to comment.