-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes after root-project/root#16443 #46195
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41993
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Thank you very much for this! This time, the update of the interface is 100 % intended and backwards compatible! I will keep my previous PR open to revert the accidental interface changes when I have done this in ROOT. |
@iarspider , you meant root-project/root#16443 ... right? |
a789d04
to
28b999c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41995
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test lets re-run based on latest IB |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1 |
@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this? |
note that is PR is needed to integrate latest |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Cherry-picking of 325c9e3 by @guitargeek
PR validation:
Bot tests in cms-sw/cmsdist#9441