Fixes after root-project/root#16443

[iarspider]

PR description:

Cherry-picking of 325c9e3 by @guitargeek

PR validation:

Bot tests in cms-sw/cmsdist#9441

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41993

• There are other open Pull requests which might conflict with changes you have proposed:
  • File OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc modified in PR(s): Follow up on recent Minuit 2 code changes #46079
  • File RecoVertex/BeamSpotProducer/interface/BSFitter.h modified in PR(s): Follow up on recent Minuit 2 code changes #46079
  • File RecoVertex/BeamSpotProducer/src/BSFitter.cc modified in PR(s): Follow up on recent Minuit 2 code changes #46079

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41993/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41993/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[guitargeek]

Thank you very much for this! This time, the update of the interface is 100 % intended and backwards compatible!

I will keep my previous PR open to revert the accidental interface changes when I have done this in ROOT.

[smuzaffar]

@iarspider , you meant root-project/root#16443 ... right?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46195/41995

• There are other open Pull requests which might conflict with changes you have proposed:
  • File OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc modified in PR(s): Follow up on recent Minuit 2 code changes #46079
  • File RecoVertex/BeamSpotProducer/interface/BSFitter.h modified in PR(s): Follow up on recent Minuit 2 code changes #46079
  • File RecoVertex/BeamSpotProducer/src/BSFitter.cc modified in PR(s): Follow up on recent Minuit 2 code changes #46079

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• OnlineDB/CSCCondDB (db)
• RecoVertex/BeamSpotProducer (alca, reconstruction)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @JanFSchulte, @PonIlya, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6acd47/41875/summary.html
COMMIT: 28b999c
CMSSW: CMSSW_14_2_X_2024-10-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46195/41875/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-tsg-storm remove unused files from HLTrigger area #46164
• @iarspider [DB] Fix syntax in python scripts #46165
• @iarspider [SIMULATION] Fix syntax in python scripts #46167
• @Dr15Jones Initialize all member data in CaloSD constructor #46162
• @iarspider [ALCA] Fix syntax in python scripts #46163
• @mandrenguyen Use repacked raw for 2024 UPC processing #46192
• @perrotta Remove a dead assignment in CondFormats/SiStripObjects/src/SiStripThreshold.cc #46174
• @perrotta Update Run3 data, Run3 2024 pp MC, Run3 2024 ppRef5TeV MC GTs in autoCond #46184
• @rovere Fix HLT Phase2 timing script. #46185
• @smuzaffar run G2GainsValidator.py in user-mode #46179
• @CMSTrackerDPG fix SiStripLatency methods when object is empty #46149
• @iarspider [ANALYSIS] Fix syntax in python scripts #46172
• @iarspider [GEOMETRY] Fix syntax in python scripts #46171
• @iarspider [RECONSTRUCTION] Fix syntax in python scripts #46170
• @Dr15Jones Replace usleep with std::this_thread::sleep_for #46143
• @Moanwar Add usePCACleaning to CLUE3DHighStep_cff and fix HFNose seeded region #46152

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6acd47/41875/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6acd47/41875/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreConcurrency had ERRORS

RelVals-INPUT

• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
• 2024.1010012024.101001_RunZeroBias2024C_10k/step1_dasquery.log
• 2024.100001DAS Error

Expand to see more relval errors ...

• 2024.101001

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 848 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3438008
• DQMHistoTests: Total failures: 4097
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3433891
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

lets re-run based on latest IB

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6acd47/41893/summary.html
COMMIT: 28b999c
CMSSW: CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46195/41893/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 104 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3438008
• DQMHistoTests: Total failures: 3382
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3434606
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[smuzaffar]

@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this?

[smuzaffar]

note that is PR is needed to integrate latest ROOT master changes (cms-sw/cmsdist#9441)

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1