Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused files from HLTrigger area #46164

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 1, 2024

PR description:

Issue #46113, which discussed the deprecation of the imp package from python 3.12, made us realize that some of the files that still import it, are in fact unused and substantially unsupported from at least LS2.

HLTrigger/Configuration/test/add/tracingImport.py:import sys, imp,
HLTrigger/Tools/python/PDRates.py:import sys, imp

this PR proposes to just remove them, thus solving the deprecation problem.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • HLTrigger/Tools (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 1, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831874/41827/summary.html
COMMIT: d1e1f98
CMSSW: CMSSW_14_2_X_2024-09-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46164/41827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 1, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f5e0f3d into cms-sw:master Oct 2, 2024
11 checks passed
@mmusich mmusich deleted the dev_remove_unused_files_14_2_X branch October 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants