Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit copy-constructor from TotemTimingDigi #43315

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove explicit copy-constructor from TotemTimingDigi #43315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions DataFormats/CTPPSDigi/interface/TotemTimingDigi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ class TotemTimingDigi {
const uint16_t cellInfo,
const std::vector<uint8_t>& samples,
const TotemTimingEventInfo& totemTimingEventInfo);
TotemTimingDigi(const TotemTimingDigi& digi);
TotemTimingDigi();
~TotemTimingDigi(){};

/// Digis are equal if they have all the same values, NOT checking the samples!
bool operator==(const TotemTimingDigi& digi) const;
Expand Down
2 changes: 0 additions & 2 deletions DataFormats/CTPPSDigi/interface/TotemTimingEventInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ class TotemTimingEventInfo {
const uint8_t numberOfSamples,
const uint8_t offsetOfSamples,
const uint8_t pllInfo);
TotemTimingEventInfo(const TotemTimingEventInfo& eventInfo);
TotemTimingEventInfo();
~TotemTimingEventInfo(){};

/// Digis are equal if they have all the same values, NOT checking the samples!
bool operator==(const TotemTimingEventInfo& eventInfo) const;
Expand Down
9 changes: 0 additions & 9 deletions DataFormats/CTPPSDigi/src/TotemTimingDigi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,6 @@ TotemTimingDigi::TotemTimingDigi(const uint8_t hwId,
samples_(samples),
totemTimingEventInfo_(totemTimingEventInfo) {}

TotemTimingDigi::TotemTimingDigi(const TotemTimingDigi& digi)
: hwId_(digi.hwId_),
fpgaTimestamp_(digi.fpgaTimestamp_),
timestampA_(digi.timestampA_),
timestampB_(digi.timestampB_),
cellInfo_(digi.cellInfo_),
samples_(digi.samples_),
totemTimingEventInfo_(digi.totemTimingEventInfo_) {}

TotemTimingDigi::TotemTimingDigi() : hwId_(0), fpgaTimestamp_(0), timestampA_(0), timestampB_(0), cellInfo_(0) {}

// Comparison
Expand Down
12 changes: 0 additions & 12 deletions DataFormats/CTPPSDigi/src/TotemTimingEventInfo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,6 @@ TotemTimingEventInfo::TotemTimingEventInfo(const uint8_t hwId,
offsetOfSamples_(offsetOfSamples),
pllInfo_(pllInfo) {}

TotemTimingEventInfo::TotemTimingEventInfo(const TotemTimingEventInfo& eventInfo)
: hwId_(eventInfo.hwId_),
l1ATimestamp_(eventInfo.l1ATimestamp_),
bunchNumber_(eventInfo.bunchNumber_),
orbitNumber_(eventInfo.orbitNumber_),
eventNumber_(eventInfo.eventNumber_),
channelMap_(eventInfo.channelMap_),
l1ALatency_(eventInfo.l1ALatency_),
numberOfSamples_(eventInfo.numberOfSamples_),
offsetOfSamples_(eventInfo.offsetOfSamples_),
pllInfo_(eventInfo.pllInfo_) {}

TotemTimingEventInfo::TotemTimingEventInfo()
: hwId_(0),
l1ATimestamp_(0),
Expand Down