Remove explicit copy-constructor from TotemTimingDigi

[iarspider]

PR description:

Implicit copy-constructors are deprecated, and not necessary in most cases. This PR removes unnnecessary copy-assignment operators and destructors in favor of auto-generated ones.

PR validation:

Bot tests

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43315/37767

• This PR adds an extra 20KB to repository

[iarspider]

please test for CMSSW_14_0_DEVEL_X

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/CTPPSDigi (reconstruction, simulation)

@jfernan2, @mandrenguyen, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@rovere, @grzanka, @missirol, @fabferro this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0facaa/35924/summary.html
COMMIT: dfb8db9
CMSSW: CMSSW_14_0_X_2023-11-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43315/35924/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 441 lines to the logs
• Reco comparison results: 134 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 1789
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361259
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0facaa/35922/summary.html
COMMIT: dfb8db9
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43315/35922/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Change Sonic to use ExternalFailure exception #43274

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0facaa/35922/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0facaa/35922/git-merge-result

Comparison Summary

Summary:

• You potentially removed 215 lines from the logs
• Reco comparison results: 136 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 2401
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3360647
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1