Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

era to store ZDC digis for pp reco [13_2_X] #42944

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mandrenguyen
Copy link
Contributor

backport of #42942

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • Configuration/Eras (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/PatAlgos (reconstruction, xpog)
  • RecoLocalCalo/Configuration (reconstruction)

@vlimant, @davidlange6, @fabiocos, @rappoccio, @antoniovilela, @jfernan2, @simonepigazzini, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @nhanvtran, @jdamgov, @AnnikaStein, @schoef, @Martin-Grunewald, @mariadalfonso, @missirol, @hatakeyamak, @sameasy, @andrzejnovak, @youyingli, @JyothsnaKomaragiri, @apsallid, @wang0jin, @ebrondol, @ahinzmann, @gouskos, @VinInn, @rovere, @gpetruc, @azotz, @rappoccio, @thomreis, @mbluj, @JanFSchulte, @dgulhan, @emilbols, @gkasieczka, @seemasharmafnal, @jdolen, @VourMa, @Ming-Yan, @demuller, @Senphy, @GiacomoSguazzoni, @mtosi, @felicepantaleo, @mmarionncern, @mmusich, @AlexDeMoor, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5341b6/35039/summary.html
COMMIT: a2cafc1
CMSSW: CMSSW_13_2_X_2023-10-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42944/35039/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198423
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198395
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

urgent
likely to be needed for data taking pending decision at daily ops meeting tomorrow

@mandrenguyen
Copy link
Contributor Author

+1

@simonepigazzini
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 367d39d into cms-sw:CMSSW_13_2_X Oct 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants