Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

era to store ZDC digis for pp reco #42942

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mandrenguyen
Copy link
Contributor

@mandrenguyen mandrenguyen commented Oct 4, 2023

PR description:

Add an variant of the ongoing pp era Run_2023, which stores the ZDC digis Run_2023_ZDC.
This information is already stored in the heavy-ion eras.
I also updated the T0 processing era ppEra_Run3_2023_repacked to use this option.
The idea is to test whether the HIForward datasets can now be reconstructed with standard pp settings, now that the HLT V1.1 has been deployed, which removes the (heavy) hadronic interactions.

PR validation:

Tested at driver level, by modifying 140.6 by hand.
Will need to be tested in a T0 replay.

Backport to 13_2_X will be made.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42942/37089

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • Configuration/Eras (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoLocalCalo/Configuration (reconstruction)

@rappoccio, @mandrenguyen, @fabiocos, @vlimant, @jfernan2, @antoniovilela, @cmsbuild, @davidlange6, @simonepigazzini can you please review it and eventually sign? Thanks.
@slomeo, @emilbols, @AnnikaStein, @JyothsnaKomaragiri, @dgulhan, @missirol, @apsallid, @ahinzmann, @Ming-Yan, @mariadalfonso, @mmusich, @Martin-Grunewald, @gouskos, @seemasharmafnal, @felicepantaleo, @mtosi, @jdamgov, @azotz, @makortel, @gpetruc, @Senphy, @thomreis, @rappoccio, @GiacomoSguazzoni, @mmarionncern, @demuller, @VourMa, @hatakeyamak, @wang0jin, @sameasy, @andrzejnovak, @mbluj, @schoef, @jdolen, @ebrondol, @fabiocos, @nhanvtran, @youyingli, @gkasieczka, @rovere, @JanFSchulte, @VinInn, @AlexDeMoor this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4e420/35038/summary.html
COMMIT: 1fa1ced
CMSSW: CMSSW_13_3_X_2023-10-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42942/35038/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358289
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4e420/35044/summary.html
COMMIT: 1fa1ced
CMSSW: CMSSW_13_3_X_2023-10-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42942/35044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

+1

@mandrenguyen
Copy link
Contributor Author

urgent
likely to be needed for data taking pending decision at daily ops meeting tomorrow

@cmsbuild cmsbuild added the urgent label Oct 4, 2023
@simonepigazzini
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit aca7593 into cms-sw:master Oct 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants