-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JMENanoAOD] Updates for Run-3 #39000
Conversation
- Update name of NanoAOD-related config files and modules - Add adedicated function for reclustering and content customisation of AK4 Puppi jets. - Recluster both AK4 CHS and AK4 Puppi jet collections but modify their table names and content depending on eras (i.e Run-2 or Run-3).
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39000/31469
|
A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master. It involves the following packages:
@gouskos, @swertz, @jordan-martins, @vlimant, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
2 and 5 can be done in a future PRs |
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leadTrackPt = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRel = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRatio = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRelInv = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRelv0 = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRatiov0 = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPtRelInvv0 = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonDeltaR = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, leptonPt = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, vtxPt = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, vtxMass = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, vtx3dL = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, vtx3deL = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, ptD = None) | ||
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats, genPtwNu = None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make multiple modifications in a single toModify()
statement (and therefore you should, in order to reduce duplication). example:
(~run2_nanoAOD_ANY).toModify(proc.updatedJetsWithUserData.userFloats,
leadTrackPt = None,
leptonPtRel = None,
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Will clean up.
proc.nanoTableTaskCommon.add(proc.jetPuppiForMETTask) | ||
return proc | ||
|
||
jmeNano_addAK4JetTaks_switch = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix typo Taks -> Task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be corrected.
I don't think any of them is Run-3.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39000/31470
|
seems we have twice this branch |
@mariadalfonso I could only find one branch with the name |
+xpog seems fine from technical point of view. to be done ASAP: 2 and 5 from here |
+reconstruction
|
+Upgrade From the upgrade side, this PR update the workflows for JMENano. Workflow runs fine. For technical topics, i.e. contents or speed up, please follow up with @cms-sw/xpog-l2. |
@nurfikri89 please backport to 12_4 |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
@mariadalfonso @cms-sw/pdmv-l2 @nurfikri89 |
The DQM was just never in the release. Once this is added we can aim to test it:
The 12B of UL dataset were submitted by PPD for FWK validation and BLINDLY. Also all the presentation shown at PPD never included a single plot and nd PRs desciption never contain distributions. |
…un3_forPR [JMENanoAOD] Backport of #39000 (Updates for Run-3) to 12_4_X
PR description:
This PR updates JMENano to be compatible with Run-3 data and MC, starting with the upcoming NanoAODv10 production. The following major changes are made:
Sequences
have been changed toTasks
and JMENano can now run in Prompt.PR validation:
runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15
With this PR, the event size is 6.24 kb/event. Test was done using 10K events from a TTTo2J1L1Nu Run3Winter22MiniAOD file. Below is the CPU time:
The full content and size details can be found in the JMENano twiki: content / size
if this PR is a backport please specify the original PR and why you need to backport that PR:
Once merged, this PR needs to be backported to 12_4_X for the JMENanoAODv10 production.