-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlcaPCCIntegrator
modules to the AlCa no ConcurrentLumis list
#37130
Conversation
test parameters:
|
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28661
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: RelVals-THREADING The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-THREADING
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28669
|
82b2552
to
a9ee76f
Compare
Thanks @mmusich for the fix! I've pushed it. I propose that we merge this quick fix, so that pre6 doesnt have an issue, and then we ask the Lumi team to develop the thread-safe version of |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37130/28691
|
@cmsbuild , please test |
Pull request #37130 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ba25/22861/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
type bug-fix |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
A possible fix for
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_3_X_2022-03-02-2300/pyRelValMatrixLogs/run/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP/step2_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP.log#/
PR validation:
None, will test it in Jenkins with multi-threaded options
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A