Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1TrackTrigger step to DD4hep #37005

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Feb 21, 2022

PR description:

This is a PR to handle the DD4hep for L1TrackTrigger step. The overall discussion on DIGI-L1-HLT step is at #36837

Remaining question include

  • Do we still need to check the supported geometry? It is currently hardcoding on XML filename.
    This can be followed in the follow up PR.

PR validation:

Using runTheMatrix.py --what upgrade -l 39434.0,39434.911 --wm init

  • Running with DDD workflow, no change is expected.
  • Running DD4hep workflow, a job can now pass the L1TrackTrigger step.
----- Begin Fatal Exception 20-Feb-2022 16:45:03 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module L1FPGATrackProducer/'TTTracksFromExtendedTrackletEmulation'
   [2] Calling method for EventSetup module trackerDTC::ProducerES/'TrackTriggerSetup'
Exception Message:
NullPointer 
----- End Fatal Exception -------------------------------------------------

To run with full step, one can trigger the test as in #37078 (comment)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no need to backport

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37005/28424

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37005/28425

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37005/28438

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37005/28440

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • L1Trigger/TrackerDTC (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @skinnari, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob srimanob marked this pull request as ready for review February 25, 2022 07:54
@srimanob srimanob changed the title [Not to merge] Update L1TrackTrigger step to DD4hep Update L1TrackTrigger step to DD4hep Feb 27, 2022
@srimanob
Copy link
Contributor Author

srimanob commented Feb 27, 2022

Hi @tschuh @cms-sw/l1-l2
I think this PR is ready to review and to merge. Could you please? Thanks.
Then we can follow on unifying the config file of DDD and DD4hep, code clean up.

PR description is updated.

DD4hep phase-2 wf is now run-able with this PR, together with #37078 and #37079

Test result is as expected,
#37079 (comment)

@srimanob
Copy link
Contributor Author

+Upgrade

This PR will make Phase-2 D88 DD4hep wf runs until complete. The config clean up, geometry checking code for DD4hep should come in the follow up PR. PR test result is as expected, #37079 (comment)

@srimanob
Copy link
Contributor Author

srimanob commented Mar 2, 2022

Kindly ping @cms-sw/l1-l2
Thanks.

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor Author

srimanob commented Mar 2, 2022

@cmsbuild please test

Just for refresh the result as the last test was more than a week. The result for standalone test is no change is expected.

The test with #37078 shows us that DD4hep Phase-2 wf can run now,
#37078 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03a696/22780/summary.html
COMMIT: adf9a90
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37005/22780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3990927
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3990891
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Mar 3, 2022

I think this PR is ready to go. The failure of wfs 312.0 and 25202.0 does not related to this PR as no L1Track is used in Run-1 and Run-2.

@qliphy
Copy link
Contributor

qliphy commented Mar 3, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants