-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to cmsDriver for selecting the accelerators to use #37128
Conversation
assign heterogeneous |
@makortel does this seem the right approach to you ? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37128/28657
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@perrotta, @makortel, @cmsbuild, @fwyzard, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Looks reasonable, thanks. Another thing I have been thinking about (but didn't have the moment to get to) was to make the |
7d147f7
to
2030726
Compare
Eh... I admit that I am a bit confused by the various "options", their intended behaviour, and their interplay. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37128/28663
|
+heterogeneous |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-986aef/22808/summary.html Comparison SummarySummary:
|
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add an option to cmsDriver for passing a comma-separated list of accelerators to enable. If none of those accelerators is available, and 'cpu' is not part of the list, the job will fail.
The default value is not set, which enables all available accelerators, including the cpu fallback.
PR validation:
Tested that
cmsDriver.py ... --accelerator gpu-nvidia
behaves as expected.