ECAL DQM - Add WF .513 for ECAL GPU vs. CPU validation

[thomreis]

PR description:

This PR adds a new type of WFs with suffix .515 .513 to do the ECAL GPU vs. CPU validation. It also addresses an issue with the configuration raised during the review of #36742 .
Both changes are tracked in #37025.

The WF suffix .515 was chosen because the initially planned .513 is foreseen for a GPU with CPU fallback WF now.

PR validation:

Passes 11634.513 and validation histograms are produced.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37123/28647

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, DeepSC algorithm for ECAL SuperClusters #37115, Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)
• DQM/EcalMonitorTasks (dqm)

@jordan-martins, @bbilin, @wajidalikhan, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @kskovpen, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @argiro, @Martin-Grunewald, @missirol, @rchatter, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[thomreis]

Addresses the ECAL part of #37075 albeit with a different suffix. Could be changed if desired.

[thomreis]

@alejands @fwyzard FYI

[srimanob]

test parameters:

• workflow = 11634.515
• enable_test = gpu
• relvals_opt = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

[srimanob]

@thomreis
Please add the new workflow to the list in
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/README.md

[srimanob]

@cmsbuild please test

[fwyzard]

hold

[cmsbuild]

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fwyzard]

A GPU workflow with fallback to CPU exists already, and is the .512 one. Can you use .513 here ?

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1065c/22793/summary.html
COMMIT: adbbc2c
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37123/22793/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.515

----- Begin Fatal Exception 03-Mar-2022 04:44:37 CET-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module EcalDQMonitorTask/'ecalMonitorTaskEcalOnly'
   [3] Prefetching for module EcalCPUDigisProducer/'ecalDigis@cuda'
   [4] Prefetching for module EcalRawToDigiGPU/'ecalDigisGPU'
   [5] Calling method for EventSetup module EcalElectronicsMappingGPUESProducer/'ecalElectronicsMappingGPUESProducer'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19811
• DQMHistoTests: Total failures: 2158
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 17653
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #37123 was updated. @jordan-martins, @makortel, @bbilin, @wajidalikhan, @emanueleusai, @ahmad3213, @AdrianoDee, @srimanob, @jfernan2, @kskovpen, @fwyzard, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1065c/22839/summary.html
COMMIT: f9271b0
CMSSW: CMSSW_12_3_X_2022-03-04-0800/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37123/22839/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a1065c/11634.513_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19811
• DQMHistoTests: Total failures: 1579
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18232
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 1 / 3 workflows

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3987741
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3987711
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[fwyzard]

+1

[AdrianoDee]

+upgrade

[thomreis]

@cms-sw/pdmv-l2 do you have any comments?

[kskovpen]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1