-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL DQM - Add WF .513 for ECAL GPU vs. CPU validation #37123
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37123/28647
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @kskovpen, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Addresses the ECAL part of #37075 albeit with a different suffix. Could be changed if desired. |
test parameters:
|
@thomreis |
@cmsbuild please test |
hold
|
Pull request has been put on hold by @fwyzard |
A GPU workflow with fallback to CPU exists already, and is the .512 one. Can you use .513 here ? |
-1 Failed Tests: RelVals RelVals
GPU Comparison SummarySummary:
|
Pull request #37123 was updated. @jordan-martins, @makortel, @bbilin, @wajidalikhan, @emanueleusai, @ahmad3213, @AdrianoDee, @srimanob, @jfernan2, @kskovpen, @fwyzard, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1065c/22839/summary.html GPU Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
Comparison SummarySummary:
|
+1 |
+1 |
+upgrade |
@cms-sw/pdmv-l2 do you have any comments? |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds a new type of WFs with suffix
.515.513 to do the ECAL GPU vs. CPU validation. It also addresses an issue with the configuration raised during the review of #36742 .Both changes are tracked in #37025.
The WF suffix .515 was chosen because the initially planned .513 is foreseen for a GPU with CPU fallback WF now.PR validation:
Passes 11634.513 and validation histograms are produced.