Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate CalibTracker/SiStripQuality #37120

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 2, 2022

PR description:

The purpose of this PR is to consolidate the package CalibTracker/SiStripQuality.

  • plugins in the CalibTracker/SiStripQuality/plugins directory with an header file have been merged together with their implementation file;
  • the SealModule file in the same directory is removed;
  • SiStripBadStripFromASCIIFile.ccis moved from CalibTracker/SiStripQuality to CondTools/SiStrip (where it belongs)
  • a fillPSetDescription method has been added to ConditionDBWriter such that it can be used to populate the configuration descriptors of the inherited classes;
  • SiStripBadStripFromASCIIFile_cfg.py configuration has been modernized and included in the package unit tests.
  • the file CalibTracker/SiStripQuality/data/DefectsFromConstructionDB.dat is removed from cmssw and put in the cms-data repo in PR add DefectsFromConstructionDB.dat to CondTools/SiStrip data repo cms-data/CondTools-SiStrip#2;
  • finally there is a general code clean-up and modernization;

PR validation:

Relies on the (augmented) unit tests of CondTools/SiStrip.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37120/28640

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiStripQuality (alca)
  • CommonTools/ConditionDBWriter (db)
  • CondTools/SiStrip (db)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @VinInn, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 2, 2022

@cmsbuild, please test with cms-data/CondTools-SiStrip#2

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22781/summary.html
COMMIT: 7d9cbdf
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37120/22781/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22781/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22781/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987333
  • DQMHistoTests: Total failures: 157
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3987147
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6538.534 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1091.170 KiB HLT/BPH
  • DQMHistoSizes: changed ( 11634.0,... ): 1.415 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@tvami
Copy link
Contributor

tvami commented Mar 2, 2022

@cmsbuild, please test with cms-data/CondTools-SiStrip#2

  • let's test this in a clean IB

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22789/summary.html
COMMIT: 7d9cbdf
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37120/22789/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22789/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22789/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987333
  • DQMHistoTests: Total failures: 157
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3987147
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6538.534 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1091.170 KiB HLT/BPH
  • DQMHistoSizes: changed ( 11634.0,... ): 1.415 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@francescobrivio
Copy link
Contributor

This picked up the same IB, so not really a clean comparison. Let's try again.

@francescobrivio
Copy link
Contributor

@cmsbuild please test with cms-data/CondTools-SiStrip#2

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e5adb/22804/summary.html
COMMIT: 7d9cbdf
CMSSW: CMSSW_12_3_X_2022-03-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37120/22804/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3987705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 4, 2022

+1

@cmsbuild cmsbuild merged commit a92ffe2 into cms-sw:master Mar 4, 2022
@mmusich mmusich deleted the consolidateCalibTrackerSiStripQuality branch March 4, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants