-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Add error message for undefined solid #37112
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37112/28614
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d55c6/22756/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
When processing XML files with DD4hep, if a solid is referenced before it is defined, in some cases a cryptic exception will be generated. Issue #31198 requested a more explanatory error message for this case.This PR adds an error message that names the missing solid and recommends to the user that the XML files need to be re-ordered to prevent references to undefined solids.
PR validation:
The XML geometry configuration for Phase 2 D88 was re-ordered so that the
muonBase:MUON
solid was referenced before it was defined by movingcavern.xml
beforemuonBase.xml
. This bad order then generated the new error message.No backport is needed.