Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-alca193 Add DQM for HcalIterativePhiSymAlCaReco #34784

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 5, 2021

PR description:

Add DQM for HcalIterativePhiSymAlCaReco

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34784/24466

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda bsunanda changed the title Run3-alca191 Add DQM for HcalIterativePhiSymAlCaReco Run3-alca193 Add DQM for HcalIterativePhiSymAlCaReco Aug 5, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34784/24467

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQMOffline/CalibCalo (dqm)
  • DQMOffline/Configuration (dqm)

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @silviodonato, @jfernan2, @qliphy, @davidlange6, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @fabiocos, @lecriste, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @thomreis, @threus, @simonepigazzini, @ebrondol, @mmusich, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 5, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-172b31/17552/summary.html
COMMIT: 9512079
CMSSW: CMSSW_12_1_X_2021-08-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34784/17552/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 05-Aug-2021 06:34:49 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=DQMHcalIterativePhiSymAlCaReco label='ALCARECOHcalCalIterativePhisymDQM'
Exception Message:
MissingParameter: Parameter 'FolderName' not found.
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 1000.01000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34784/24488

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

Pull request #34784 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @silviodonato, @jfernan2, @qliphy, @davidlange6, @fabiocos, @rvenditti can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 5, 2021

@cmsbuild Please test

@tvami
Copy link
Contributor

tvami commented Aug 5, 2021

resolves #34777

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-172b31/17562/summary.html
COMMIT: 5efe01c
CMSSW: CMSSW_12_1_X_2021-08-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34784/17562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2999377
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 173.573 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth1
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth2
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth3
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth4
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth5
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth6
  • DQMHistoSizes: changed ( 1000.0 ): 24.607 KiB ALCAStreamHcalIterativePhiSym/MBdepth7
  • DQMHistoSizes: changed ( 1000.0 ): 0.440 KiB ALCAStreamHcalIterativePhiSym/DistrHBHEsize
  • DQMHistoSizes: changed ( 1000.0 ): 0.438 KiB ALCAStreamHcalIterativePhiSym/DistrHFsize
  • DQMHistoSizes: changed ( 1000.0 ): 0.438 KiB ALCAStreamHcalIterativePhiSym/DistrHOsize
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 6, 2021

@jfernan2 Can you sign off this PR?

@Dr15Jones
Copy link
Contributor

Ping @cms-sw/dqm-l2

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17eaabf into cms-sw:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants