Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in ALCARECOHcal paths #34777

Closed
Dr15Jones opened this issue Aug 4, 2021 · 11 comments
Closed

Inconsistency in ALCARECOHcal paths #34777

Dr15Jones opened this issue Aug 4, 2021 · 11 comments

Comments

@Dr15Jones
Copy link
Contributor

The new schedule consistency checker, #34735 , found the following problem in RelVal 1000.0

----- Begin Fatal Exception 03-Aug-2021 23:03:32 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Paths are non consistent
  module 'ALCARECOHcalCalPhisymDQM' depends on 'hbherecoNoise' which appears on paths
  pathALCARECOHcalCalMinBias 
but is missing from
  pathALCARECOHcalCalIterativePhiSym 
----- End Fatal Exception -------------------------------------------------

looking at the configuration, hbherecoNoise only appears on pathALCARECOHcalCalMinBias which means pathALCARECOHcalCalIterativePhiSym can not operate without that other path being present.

@Dr15Jones
Copy link
Contributor Author

assign alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

New categories assigned: alca

@francescobrivio,@tvami,@malbouis,@pohsun,@tlampen,@yuanchao you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @perrotta, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

The configuration fragments are

seqALCARECOHcalCalMinBias = cms.Sequence(hbherecoMBNZS*horecoMBNZS*hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)

pathALCARECOHcalCalMinBias = cms.Path(seqALCARECOHcalCalMinBiasDigi*seqALCARECOHcalCalMinBias*ALCARECOHcalCalPhisymDQM)

pathALCARECOHcalCalIterativePhiSym = cms.Path(seqALCARECOHcalCalIterativePhiSym*ALCARECOHcalCalPhisymDQM)

@tvami
Copy link
Contributor

tvami commented Aug 4, 2021

Hi @bsunanda can you please look into this? Thanks!

@Dr15Jones
Copy link
Contributor Author

One thing to know, the Paths pathALCARECOHcalCalMinBias and pathALCARECOHcalCalIterativePhiSym both start with different filters. If the filter on Path pathALCARECOHcalCalMinBias fails and the filter on path pathALCARECOHcalCalIterativePhiSym succeeds, then when ALCARECOHcalCalPhisymDQM is called, the EDAnalyzer will fail to get the data products it needs (since they were only defined on Path pathALCARECOHcalCalMinBias).

@bsunanda
Copy link
Contributor

bsunanda commented Aug 4, 2021

The two paths produce different outputs and the same DQMAnalyzer should not be used for both. I am trying to see if a second DQM analyzer can be made for pathALCARECOHcalCalIterativePhiSym

@bsunanda
Copy link
Contributor

bsunanda commented Aug 5, 2021

Submitted a PR #34784 to resolve this issue.

@perrotta
Copy link
Contributor

As this isssue is fixed by #34784, it can probably be signed and closed

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants