-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and examples #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this PR, added a few remarks below 👍
These changes look similar to clue/reactphp-sqlite#43, maybe include a reference to this ticket in your description and update the title?
Thank you @SimonFrings for informing me about this. Changes should be okay by now, I also changed the title of this pull request and added the references. Thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for looking into this, changes LGTM!
This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.
Builds on top of: clue/reactphp-sqlite#43.