Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and examples #17

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 30, 2024

Builds on top of #11 and #8.

References: clue/reactphp-tar#20 and clue/reactphp-sqlite#43.

@yadaiio
Copy link
Contributor Author

yadaiio commented Jan 30, 2024

This pull request would run green after the pull request #16 will be merged. I would rebase this pull request afterwards.

README.md Outdated Show resolved Hide resolved
@yadaiio
Copy link
Contributor Author

yadaiio commented Feb 20, 2024

This pull request is rebased now and ready for a review. 😎

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SimonFrings SimonFrings requested a review from clue February 20, 2024 16:05
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this! Here's a minor suggestion while we're at it:

README.md Show resolved Hide resolved
@clue clue added this to the v0.1.0 milestone Feb 21, 2024
@clue clue added the documentation Improvements or additions to documentation label Feb 21, 2024
@yadaiio yadaiio requested a review from clue February 22, 2024 07:11
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
examples/demo.php Outdated Show resolved Hide resolved
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@SimonFrings SimonFrings merged commit da2e173 into clue:master Apr 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants