This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Diagnosed remaining assembly errors #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorklang
reviewed
May 1, 2020
| // This one is different in akka-protobuf-v3. | ||
| // We should still not ship these .proto's in akka-persistence-spanner | ||
| // and not in akka-protobuf-v3, though. | ||
| case "google/protobuf/field_mask.proto" => MergeStrategy.first |
There was a problem hiding this comment.
I think you can safely discard all ".proto"-files since the fat jar will not have them used for anything, it's only intended to be executed via java -jar
hseeberger
force-pushed
the
proxy-spanner
branch
3 times, most recently
from
112c889 to
a5d0763
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a couple remaining after https://github.com/akka/akka-persistence-spanner/pull/74
and akka/akka-grpc#943