Avoid shipping classes already in scalapb-runtime #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
added a commit
to raboof/cloudstate
that referenced
this pull request
Apr 30, 2020
To a version that has akka/akka-grpc#943 to fix compilation errors. Compile/test now works, but assembly still has problems, and the PR needs a rebase.
jrudolph
approved these changes
Apr 30, 2020
| @@ -4,3 +4,7 @@ $ exists target/scala-2.12/src_managed | |||
| $ exists target/scala-2.12/src_managed/main/example/myapp/helloworld/grpc/HelloRequest.scala | |||
| $ exists target/scala-2.12/src_managed/main/example/myapp/helloworld/grpc/HelloworldProto.scala | |||
| $ exists target/scala-2.12/src_managed/main/example/myapp/helloworld/grpc/GreeterService.scala | |||
|
|
|||
| # This will for example detect when we publish generated code that is | |||
| # already in scalapb-runtime | |||
There was a problem hiding this comment.
Because there would be exactly the same files at the same path now clashing?
There was a problem hiding this comment.
Yes - actually not exactly the same, scalapb generates additional methods (they enable the javaConversions option)
viktorklang
added a commit
to cloudstateio/cloudstate
that referenced
this pull request
Apr 30, 2020
* Update Akka gRPC to 0.8.0 Unfortunately running into akka/akka-grpc#628 now * Update to 0.8.1 * Update akka-grpc To a version that has akka/akka-grpc#943 to fix compilation errors. Compile/test now works, but assembly still has problems, and the PR needs a rebase. * Remove reflection proto Reflection is provided by akka-grpc. Perhaps we'd like to make the .proto available here for some reason, but we shouldn't generate code for it. * reuse writer, shorter codec negotiation * Update to published akka-grpc snapshot * Expect server reflection in the reflection in the TCK Co-authored-by: Arnout Engelen <[email protected]>
raboof
added a commit
to raboof/cloudstate
that referenced
this pull request
May 1, 2020
Only a couple remaining after https://github.com/akka/akka-persistence-spanner/pull/74 and akka/akka-grpc#943
pvlugter
pushed a commit
to lightbend/kalix-jvm-sdk
that referenced
this pull request
Feb 19, 2021
* Update Akka gRPC to 0.8.0 Unfortunately running into akka/akka-grpc#628 now * Update to 0.8.1 * Update akka-grpc To a version that has akka/akka-grpc#943 to fix compilation errors. Compile/test now works, but assembly still has problems, and the PR needs a rebase. * Remove reflection proto Reflection is provided by akka-grpc. Perhaps we'd like to make the .proto available here for some reason, but we shouldn't generate code for it. * reuse writer, shorter codec negotiation * Update to published akka-grpc snapshot * Expect server reflection in the reflection in the TCK Co-authored-by: Arnout Engelen <[email protected]>
pvlugter
pushed a commit
to lightbend/kalix-jvm-sdk
that referenced
this pull request
May 26, 2021
* Update Akka gRPC to 0.8.0 Unfortunately running into akka/akka-grpc#628 now * Update to 0.8.1 * Update akka-grpc To a version that has akka/akka-grpc#943 to fix compilation errors. Compile/test now works, but assembly still has problems, and the PR needs a rebase. * Remove reflection proto Reflection is provided by akka-grpc. Perhaps we'd like to make the .proto available here for some reason, but we shouldn't generate code for it. * reuse writer, shorter codec negotiation * Update to published akka-grpc snapshot * Expect server reflection in the reflection in the TCK Co-authored-by: Arnout Engelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.