Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudwatch log group enabled #61

Merged
merged 8 commits into from
Jul 28, 2020
Merged

Cloudwatch log group enabled #61

merged 8 commits into from
Jul 28, 2020

Conversation

nitrocode
Copy link
Member

what

  • Disable cloudwatch log group if boolean set to false

why

  • If we don't want to log to cloudwatch if we're using a custom container definition, then we should be able to disable the log group

references

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit dd868c7 into master Jul 28, 2020
@nitrocode nitrocode deleted the cloudwatch_log_group_enabled branch July 28, 2020 17:36
@nitrocode nitrocode mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland

@jhosteny jhosteny Awaiting requested review from jhosteny

@jamengual jamengual Awaiting requested review from jamengual

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overriding the container_definition
3 participants
@nitrocode @osterman @actions-bot