Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override container definitions #60

Merged
merged 8 commits into from
Jul 28, 2020
Merged

Override container definitions #60

merged 8 commits into from
Jul 28, 2020

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jul 27, 2020 •
edited
Loading

what

  • My use case is that I want to pass in a list of container definitions. We can append the list of container definitions using var.init_containers but unfortunately cannot overrride the main container definition.

why

  • To support other log drivers and other container definition features without having to create more logic or expose additional input variables

references

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

osterman
osterman previously approved these changes Jul 28, 2020
View reviewed changes
@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from osterman July 28, 2020 17:41
@nitrocode
Copy link
Member Author

@osterman had to fix a merge conflict after merging PR #61 which caused a dismissal of your previous review

@nitrocode nitrocode merged commit 376db54 into master Jul 28, 2020
@nitrocode nitrocode deleted the override-container-definitions branch July 28, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

@jamengual jamengual Awaiting requested review from jamengual

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overriding the container_definition
3 participants
@nitrocode @osterman @actions-bot