Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct delimiter value with nat-instance #99

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

syphernl
Copy link
Contributor

@syphernl syphernl commented Sep 8, 2020

what

  • Replaces var.delimiter with local.delimiter in nat-instance.tf

why

references

@syphernl syphernl requested review from a team as code owners September 8, 2020 10:05
@syphernl syphernl requested review from Gowiem and RothAndrew and removed request for a team September 8, 2020 10:05
@syphernl
Copy link
Contributor Author

syphernl commented Sep 8, 2020

/test all

Gowiem
Gowiem previously approved these changes Sep 8, 2020
@Gowiem
Copy link
Member

Gowiem commented Sep 8, 2020

/test all

@Gowiem
Copy link
Member

Gowiem commented Sep 8, 2020

/rebuild-readme

@Gowiem
Copy link
Member

Gowiem commented Sep 8, 2020

/test all

@Gowiem Gowiem merged commit 3361aa6 into cloudposse:master Sep 8, 2020
@Gowiem
Copy link
Member

Gowiem commented Sep 8, 2020

@syphernl Thanks for the contribution! Released as 0.29.0.

@syphernl syphernl deleted the fix/nat_instance_delimiter branch September 8, 2020 12:32
@Nuru
Copy link
Contributor

Nuru commented Sep 9, 2020

@Gowiem Thank you for reviewing and approving this PR.

Now that we are using auto-release, we are managing minor vs patch versions with labels. This PR should have been labeled "bug" or "bugfix" so that it would have been released as 0.28.1 instead of 0.29.0. You can also use the label "patch" for minor changes that are not exactly bug fixes. If the label does not exist on the repo, you can add it or as @cloudposse/engineering to add it. You can look at the labels on terraform-null-label as an example.

You can also use the "enhancement" label to highlight that the PR provides a significant new feature.

@Gowiem
Copy link
Member

Gowiem commented Sep 10, 2020

@Nuru Yeah makes sense, I botched this one. Thanks for pointing that out -- I'll keep it in mind moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants