Update to standard context, go mods, and GitHub config #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
/test all |
|
/test readme |
|
/test terratest |
1 similar comment
|
/test terratest |
|
/test all |
|
/test all |
|
/rebuild-readme |
|
/test all |
|
/test all |
aknysh
reviewed
Aug 27, 2020
nat-gateway.tf
Outdated
| enabled = var.enabled | ||
| context = module.label.context | ||
| attributes = distinct(compact(concat(module.label.attributes, ["nat"]))) | ||
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" |
There was a problem hiding this comment.
Suggested change
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" | |
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.1" |
aknysh
reviewed
Aug 27, 2020
nat-instance.tf
Outdated
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.17.0" | ||
| context = module.label.context | ||
| attributes = distinct(compact(concat(module.label.attributes, ["nat", "instance"]))) | ||
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" |
There was a problem hiding this comment.
Suggested change
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" | |
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.1" |
aknysh
reviewed
Aug 27, 2020
private.tf
Outdated
| enabled = var.enabled | ||
| context = module.label.context | ||
| attributes = compact(concat(module.label.attributes, ["private"])) | ||
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" |
There was a problem hiding this comment.
Suggested change
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.0" | |
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.1" |
aknysh
reviewed
Aug 27, 2020
public.tf
Outdated
| enabled = var.enabled | ||
| context = module.label.context | ||
| attributes = compact(concat(module.label.attributes, ["public"])) | ||
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.17.0" |
There was a problem hiding this comment.
Suggested change
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.17.0" | |
| source = "git::https://github.com/cloudposse/terraform-null-label.git?ref=tags/0.19.1" |
aknysh
reviewed
Aug 27, 2020
versions.tf
Outdated
| @@ -2,7 +2,7 @@ terraform { | |||
| required_version = ">= 0.12.0, < 0.14.0" | |||
|
|
|||
| required_providers { | |||
| aws = "~> 2.0" | |||
| aws = ">= 2.0, <=4.0" | |||
There was a problem hiding this comment.
why <=4.0?
do we want to include v4?
aknysh
reviewed
Aug 27, 2020
aknysh
previously approved these changes
Aug 27, 2020
|
/test all |
1 similar comment
|
/test all |
|
/rebuild-readme |
|
/test all |
aknysh
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Update to current standards
context.tfgomodules.githubfileswhy
Standardization and interoperability